-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide IGNORE
option for AWS_XRAY_CONTEXT_MISSING
configuration variable
#334
Comments
Thanks @NathanielRN for your bias for action! 🚀 I would vote for the
|
Thank you for raising this request! We will prioritize it as soon as we can, but would also be open to a PR to add support for this. It should be fairly straightforward to add (modifying where Nathan linked) - just be sure to document in README! |
I added a PR for this: #338 |
Description
In #52, it was noted that calls to unsupported APIs will result in exceptions that break a customer's app. We suggested a workaround where setting
AWS_XRAY_CONTEXT_MISSING=LOG_ERROR
logs instead of throwing an exception as explained in our X-Ray Java SDK Documentation.However, there are so many logs that the log file is flooded.
We should update the code to support an option like
IGNORE
so that neither an exception is raised nor a log message is printed out. (Or we can log at aDebug
log level withLOG_DEBUG
).Perhaps we can even make it only log once so that the customer can still notice the issue.
aws-xray-sdk-python/aws_xray_sdk/core/context.py
Lines 122 to 125 in f5f9c47
The text was updated successfully, but these errors were encountered: