Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 libraries require AWS SDK v1.11 to run #92

Open
ashleymercer opened this issue Aug 19, 2019 · 7 comments
Open

v2 libraries require AWS SDK v1.11 to run #92

ashleymercer opened this issue Aug 19, 2019 · 7 comments
Assignees

Comments

@ashleymercer
Copy link
Contributor

ashleymercer commented Aug 19, 2019

Since #43 this library has provided compatibility with v2 of the standard AWS SDK. However, there are still a large number of dependencies on the (old) v1.11 SDK which means that it's necessary to have both sets of libraries on the classpath for this to work correctly:

  • potential naming conflicts / code errors arise because a lot of classes are identically named (although in a different package structure)

  • increases the bulk of applications since we need to bundle jars for both v1.11 and v2 SDKs

  • additional complications such as having e.g. two sets of connection pools (one maintained by each SDK) which can lead to obscure bugs

Ideally, it would be possible to run using exclusively the v2 SDK: this is potentially quite a big undertaking since it would require rewriting large parts of the core package to remove any dependencies or v1.11, or else creating a new core-v2 project largely as a copy of core and rewriting the necessary parts.

@chanchiem
Copy link
Contributor

chanchiem commented Aug 30, 2019

Hey,

Thank you very much for bringing this to our attention. As of right now, this dependency is required because the X-Ray SDK uses version 1.11 of the AWS SDK to generate a client used for our rule and target poller threads. We aim to have the dependency on v2 of the SDK by the next major version release of our Java SDK. Please stay tuned.

Thanks!

@annedroiid
Copy link

Are there any further updates on this or timelines for when it might be released?

@willarmiros
Copy link
Contributor

willarmiros commented Apr 22, 2021

Hi @annedroiid,

We have rewritten the core X-Ray SDK to remove any dependencies on AWS SDK v1 in #145. However, we exposed references to AWS SDK classes in some of our public APIs, and as such we must maintain the dependency until our next major version, since removing it will constitute a breaking change.

We can't provide an official timeline on a 3.x release, but the dependency will be removed then.

@humanzz
Copy link
Contributor

humanzz commented Apr 22, 2021

Hi @willarmiros,
I hope u meant 3.x (not 4.x)? 😄

@willarmiros
Copy link
Contributor

@humanzz I sure did! Thanks for catching that.

@baldram
Copy link

baldram commented Jan 25, 2024

We have rewritten the core X-Ray SDK to remove any dependencies on AWS SDK v1 ... our next major version, since removing it will constitute a breaking change.

Do you have any advice on how to implement generating custom subsegments using only SDK v2? I mean, by adding a bit more library code to one's project, to then use it in their code, before AWS SDK V3 is released?
Perhaps this could help in eliminating the dependency on AWS SDK V1, in order to avoid exposure to vulnerabilities present in SDK V1.

The functionality I mean: https://github.com/aws/aws-xray-sdk-java?tab=readme-ov-file#intercept-custom-methods.

@danielhodder
Copy link

danielhodder commented Aug 19, 2024

Given AWS have announced that v1 of the Java SDK is being end-of-lifed in the next 18 months; it would be lovely if this got some love from AWS: https://aws.amazon.com/blogs/developer/announcing-end-of-support-for-aws-sdk-for-java-v1-x-on-december-31-2025/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants