You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When tracing is disabled using X-Ray SDK Configuration or by creating custom recorder instance, the pollers are still started. Reference : #80
Expected Behavior
Pollers should not be started when tracing is disabled,
Usecase
For unit testing, user can disable tracing.
For various stages such dev , alpha, beta customers may not want to enable X-Ray and not launch the X-Ray daemon. In the current scenario, pollers are unnecessary started leading to using resources.
Background
2 pollers are started in the background for DefaultSamplingStrategy
BeginSegment()
makes a sampling decision : codeIssue
When tracing is disabled using X-Ray SDK Configuration or by creating custom recorder instance, the pollers are still started. Reference : #80
Expected Behavior
Pollers should not be started when tracing is disabled,
Usecase
Solution
Add IsTracingDisabled() check in the ShouldTrace() before starting poller.
The text was updated successfully, but these errors were encountered: