Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set MaxStackFrameSize to 50 in a const variable like you do now for Exception handling #8

Closed
PaulDMendoza opened this issue Feb 17, 2018 · 2 comments
Labels

Comments

@PaulDMendoza
Copy link

The max stack frame size is cutting off the interesting bits of my Exception. If you could make that value at least configurable somehow or make it a public static value that I could set on application start that would allow me to capture more Exception details than I'm getting now. The value is currently hardcoded to 50. I haven't found any XRay docs stating 50 is a limit for the stack frame limit.

https://github.com/aws/aws-xray-sdk-dotnet/blob/191a7f085cbb8eb3e2a2121754d057db1f095e05/sdk/src/Core/Internal/Entities/Cause.cs

@yogiraj07
Copy link
Contributor

Hi @PaulDMendoza ,
Thank you for your suggestion. We will consider this configuration in our future work.

Best,
Yogi

@yogiraj07
Copy link
Contributor

Hi @PaulDMendoza ,
This feature has been release in 2.5.0. Please refer Changelog.

Thanks,
Yogi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants