-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net SDK release v3.0.0 #102
Comments
Re: Item 4: Update IPlugin interface to use async methods. I don't see how this will be possible. I took a look into what it would take, and it leads down to AWSXRayRecorderBuilder().Build(), which is a core piece of initialization, and would require making much of the library async, including places where it is probably not intended. I see two possible paths, either A) Require initialization to be performed async (don't use a static initializer), or B) Keep NetCore3.1 and lower using the WebRequest route and net5.0 and higher can utilize the sync method on HttpClient. Any thoughts? |
Re: Item 3: Drop dependency for AWS SDK for .Net. I'm also not seeing how this will be possible for several reasons:
|
This is a tracking issue for the changes going into the next major version release
v3.0.0
:1. Fixed a typo in Reservoir [PR #62]:
Changes the class and methods from
Reservior
toReservoir
.2. Update .net framework version to 4.5.2 [PR #101]:
Current SDK targets
net45
as theTargetFramework
for its projects. Since, the support for .Net Framework 4, 4.5 and 4.5.1 has officially ended, we plan to target thenet452
version. This would break customers who are using the SDK with applications targetingnet45
.3. Drop dependency on AWS SDK for .Net:
Current SDK depends on
AWSSDK.Core
andAWSSDK.XRay
to fetch sampling configuration from service. This adds a fair amount of overhead to the SDK. We aim to make the X-Ray SDK lightweight with minimal footprint on customer applications. For the v3.0, the plan is to replace AWS SDK with HTTP calls as the mechanism to fetch sampling configurations.4. Update
IPlugin
interface to use async methods:Please refer to this PR for more details.
The text was updated successfully, but these errors were encountered: