Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SAM cli --s3-bucket in SAM deploy to avoid template size limit error #1973

Closed
roneystein opened this issue Aug 10, 2020 · 6 comments
Closed

Use SAM cli --s3-bucket in SAM deploy to avoid template size limit error #1973

roneystein opened this issue Aug 10, 2020 · 6 comments
Labels
bug We can reproduce the issue and confirmed it is a bug.

Comments

@roneystein
Copy link

Is your feature request related to a problem? Please describe.
When a project's template reaches the 51,200 bytes size limit we can't have the deployment/change set done using the UI as it errors.

Describe the solution you'd like
Use the SAM cli --s3-bucket option to avoid the first size limit.

Describe alternatives you've considered
Currently there's no other alternative other than running the command line manually adding the --s3-bucket option.

Additional context
@roneystein roneystein added the feature-request New feature or enhancement. May require GitHub community feedback. label Aug 10, 2020
@hunterwerlla
Copy link
Contributor

@roneystein We already use --s3-bucket (here:

aws-toolkit-jetbrains/jetbrains-core/src/software/aws/toolkits/jetbrains/services/lambda/deploy/SamDeployDialog.kt

Line 128 in 7bb1c9d

.withParameters("--s3-bucket")
), what action are you taking that causes the error? And can you take a screenshot or copy paste the error? Thanks!

@hunterwerlla hunterwerlla added pending-release needs-response Waiting on additional info and feedback from GitHub community. (no auto closure) and removed pending-release labels Aug 18, 2020
@roneystein
Copy link
Author

Interesting. This occurs while deploying the application using the "Deploy Serverless Application" context menu action. I'm using AWS Toolkit 1.17-201 on PyCharm Community 2020.1.4 64-bit on Windows 10.
aws-intellij-sam_failure_message
When was that released?

@hunterwerlla
Copy link
Contributor

@roneystein Thanks, I see what is wrong now. SAM package uses --s3-bucket but sam deploy does not. Thanks for helping us track down the issue.

@hunterwerlla hunterwerlla changed the title Use SAM cli --s3-bucket to avoid template size limit error Use SAM cli --s3-bucket in SAM deploy to avoid template size limit error Aug 21, 2020
@hunterwerlla hunterwerlla added bug We can reproduce the issue and confirmed it is a bug. and removed feature-request New feature or enhancement. May require GitHub community feedback. labels Aug 21, 2020
@hunterwerlla hunterwerlla mentioned this issue Aug 21, 2020
Merged
@hunterwerlla hunterwerlla added pending-release and removed needs-response Waiting on additional info and feedback from GitHub community. (no auto closure) labels Aug 21, 2020
@hunterwerlla
Copy link
Contributor

This change will be in the next release, thanks for reporting this!

@jeremyc11
Copy link

I saw this bug should be fixed in version 1.18 but it still occur me in:
AWS Tooltip: 1.20 (2020-10-22)
PyCharm Community Edition 2019.3.4 on Windows

@hunterwerlla
Copy link
Contributor

@jeremyc11 Hello, if you are having issues can you please open a new issue?

@aws aws locked as resolved and limited conversation to collaborators Feb 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug We can reproduce the issue and confirmed it is a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@abrooksv @roneystein @hunterwerlla @jeremyc11