Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Degradation and Increased Allocation in AWSSDK.S3 Versions 3.7.107.4 and Above #3122

Closed
SonalCalcey opened this issue Dec 7, 2023 · 5 comments · Fixed by #3127
Assignees
Labels
bug This issue is a bug. p1 This is a high priority issue perf queued s3

Comments

@SonalCalcey
Copy link

Describe the bug

We have identified a performance degradation in our API after updating the AWSSDK.S3 package to the latest version 3.7.304.1.
Upon investigation, we have identified that performance degradation is occurring after the AWSSDK.S3 version 3.7.107.4.

Furthermore, we have done a Benchmark test for the AWS SDK.S3 versions such as

  • 3.7.107.3
  • 3.7.107.4
  • 3.7.304.1

To help you better understand the issue, we have prepared a sample description highlighting the key observations and differences.

Expected Behavior

Expected to have similar performance and allocation rate for as AWSSDK.S3 - 3.7.107.3 after the Nuget package update.

Current Behavior

(Benchmark results were taken using BenchmarkDotNet v0.13.10)

Summary for the AWS SDK.S3 3.7.107.3

s3-sdk-3 7 107 3-benchmark-result

Benchmark log: s3-sdk-3.7.107.3-benchmark.log

Summary for the AWS SDK.S3 3.7.107.4

s3-sdk-3 7 107 4-benchmark-result

Benchmark log: s3-sdk-3.7.107.4-benchmark.log

Summary for the AWS SDK.S3 3.7.304.1

s3-sdk-3 7 304 1-benchmark-result

Benchmark log: s3-sdk-3.7.304.1-benchmark.log

Reproduction Steps

Code used for the Benchmark:

code

Possible Solution

No response

Additional Information/Context

No response

AWS .NET SDK and/or Package version used

AWSSDK.S3 - 3.7.107.3
AWSSDK.S3 - 3.7.107.4
AWSSDK.S3 - 3.7.304.1

Targeted .NET Platform

.NET Framework 7

Operating System and version

Windows 10 Enterprise

@SonalCalcey SonalCalcey added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Dec 7, 2023
@ashishdhingra ashishdhingra added s3 perf needs-review and removed needs-triage This issue or PR still needs to be triaged. labels Dec 7, 2023
@dscpinheiro dscpinheiro changed the title Performance Degradation and Increased Allocation in AWSSDK.S3 Versions 3.7.107.4 and Above(short issue description) Performance Degradation and Increased Allocation in AWSSDK.S3 Versions 3.7.107.4 and Above Dec 7, 2023
@ashishdhingra
Copy link
Contributor

Perhaps issue #3116 is similar.

@ashishdhingra
Copy link
Contributor

Discussion here

@SonalCalcey
Copy link
Author

SonalCalcey commented Dec 8, 2023

The issue is kind of similar to this #3116, but each signed URL generation has a high memory allocation rate as well.

@ashishdhingra ashishdhingra added the p1 This is a high priority issue label Dec 8, 2023
@peterrsongg peterrsongg self-assigned this Dec 8, 2023
@afroz429 afroz429 assigned afroz429 and unassigned peterrsongg Dec 12, 2023
@afroz429
Copy link
Contributor

Thanks for the reporting the issue and taking time to pinpoint the exact version where the performance degradation started. These details were very helpful in identifying the root cause. The issue was with the AWSSDK Core and we resolved it in 3.7.300.18. The latest nuget packages already shipped with this fix.

Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. p1 This is a high priority issue perf queued s3
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants