From 77c17946cb6c1fc6ca12a7423c804e814cbeca24 Mon Sep 17 00:00:00 2001 From: Tyson Andre Date: Thu, 11 Feb 2021 13:48:41 -0500 Subject: [PATCH 1/2] fix(storage): fix typo in Upload.intialize (initialize) Keep the old name for now? The name was introduced in b07e71986817d7781e12d9b687532c58d5ea6ba0 when the file was added --- lib/storage/src/upload/Upload.ts | 2 +- lib/storage/src/upload/service-clients/Uploader.ts | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/storage/src/upload/Upload.ts b/lib/storage/src/upload/Upload.ts index a107121c7c742..0d3014f7f7e83 100644 --- a/lib/storage/src/upload/Upload.ts +++ b/lib/storage/src/upload/Upload.ts @@ -62,7 +62,7 @@ export class Upload extends EventEmitter { */ async done(): Promise { try { - await this.uploader.intialize(); + await this.uploader.initialize(); await this.uploader.upload(); const result = await this.uploader.complete(); return result; diff --git a/lib/storage/src/upload/service-clients/Uploader.ts b/lib/storage/src/upload/service-clients/Uploader.ts index f6235fb519a26..b073e12a19fe3 100644 --- a/lib/storage/src/upload/service-clients/Uploader.ts +++ b/lib/storage/src/upload/service-clients/Uploader.ts @@ -47,7 +47,12 @@ export abstract class Uploader extends EventEmitter { abstract _completeMultipartUpload(command: CompleteMultipartUploadRequest): Promise; abstract _abortUpload(command: AbortMultipartUploadRequest): Promise; + /** @deprecated */ async intialize() { + return this.initialize(); + } + + async initialize() { const intializeCommand = { Bucket: this.destination.Bucket, Key: this.destination.Key, From 95a3943c02a73d2e4f0160658ad169faddaa2a67 Mon Sep 17 00:00:00 2001 From: Tyson Andre Date: Thu, 11 Feb 2021 14:16:37 -0500 Subject: [PATCH 2/2] Update lib/storage/src/upload/service-clients/Uploader.ts Co-authored-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> --- lib/storage/src/upload/service-clients/Uploader.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/storage/src/upload/service-clients/Uploader.ts b/lib/storage/src/upload/service-clients/Uploader.ts index b073e12a19fe3..2a26d5cf151e9 100644 --- a/lib/storage/src/upload/service-clients/Uploader.ts +++ b/lib/storage/src/upload/service-clients/Uploader.ts @@ -47,7 +47,7 @@ export abstract class Uploader extends EventEmitter { abstract _completeMultipartUpload(command: CompleteMultipartUploadRequest): Promise; abstract _abortUpload(command: AbortMultipartUploadRequest): Promise; - /** @deprecated */ + /** @deprecated Use `initialize` instead. */ async intialize() { return this.initialize(); }