Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict in Peer Dependencies for @aws-sdk/client-sts @aws-sdk/client-secrets-manager #6098

Closed
3 tasks done
Callenowy opened this issue May 15, 2024 · 5 comments · Fixed by #6099
Closed
3 tasks done
Assignees
Labels
bug This issue is a bug. p1 This is a high priority issue

Comments

@Callenowy
Copy link

Checkboxes for prior research

Describe the bug

When installing the following packages:

npm i @aws-sdk/client-secrets-manager @aws-sdk/client-sts

The installation process results in conflicting peer dependencies.

npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: @aws-sdk/[email protected]
npm WARN Found: @aws-sdk/[email protected]
npm WARN node_modules/@aws-sdk/client-sts
npm WARN   @aws-sdk/client-sts@"*" from the root project
npm WARN   3 more (@aws-sdk/client-secrets-manager, ...)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer @aws-sdk/client-sts@"3.575.0" from @aws-sdk/[email protected]
npm WARN node_modules/@aws-sdk/credential-provider-web-identity
npm WARN   @aws-sdk/credential-provider-web-identity@"3.575.0" from @aws-sdk/[email protected]
npm WARN   node_modules/@aws-sdk/credential-provider-ini
npm WARN   1 more (@aws-sdk/credential-provider-node)
npm WARN
npm WARN Conflicting peer dependency: @aws-sdk/[email protected]
npm WARN node_modules/@aws-sdk/client-sts
npm WARN   peer @aws-sdk/client-sts@"3.575.0" from @aws-sdk/[email protected]
npm WARN   node_modules/@aws-sdk/credential-provider-web-identity
npm WARN     @aws-sdk/credential-provider-web-identity@"3.575.0" from @aws-sdk/[email protected]
npm WARN     node_modules/@aws-sdk/credential-provider-ini
npm WARN     1 more (@aws-sdk/credential-provider-node)

SDK version number

@aws-sdk/[email protected], @aws-sdk/[email protected]

Which JavaScript Runtime is this issue in?

Node.js

Details of the browser/Node.js/ReactNative version

v21.7.2

Reproduction Steps

  1. Run the npm i @aws-sdk/client-secrets-manager @aws-sdk/client-sts
  2. Observe the warning messages related to peer dependencies.

Observed Behavior

npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: @aws-sdk/[email protected]
npm WARN Found: @aws-sdk/[email protected]
npm WARN node_modules/@aws-sdk/client-sts
npm WARN   @aws-sdk/client-sts@"*" from the root project
npm WARN   3 more (@aws-sdk/client-secrets-manager, ...)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer @aws-sdk/client-sts@"3.575.0" from @aws-sdk/[email protected]
npm WARN node_modules/@aws-sdk/credential-provider-web-identity
npm WARN   @aws-sdk/credential-provider-web-identity@"3.575.0" from @aws-sdk/[email protected]
npm WARN   node_modules/@aws-sdk/credential-provider-ini
npm WARN   1 more (@aws-sdk/credential-provider-node)
npm WARN
npm WARN Conflicting peer dependency: @aws-sdk/[email protected]
npm WARN node_modules/@aws-sdk/client-sts
npm WARN   peer @aws-sdk/client-sts@"3.575.0" from @aws-sdk/[email protected]
npm WARN   node_modules/@aws-sdk/credential-provider-web-identity
npm WARN     @aws-sdk/credential-provider-web-identity@"3.575.0" from @aws-sdk/[email protected]
npm WARN     node_modules/@aws-sdk/credential-provider-ini
npm WARN     1 more (@aws-sdk/credential-provider-node)

Expected Behavior

The installation process should resolve peer dependencies without conflicts.

Possible Solution

No response

Additional Information/Context

No response

@Callenowy Callenowy added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels May 15, 2024
@kuhe kuhe added p1 This is a high priority issue p2 This is a standard priority issue and removed needs-triage This issue or PR still needs to be triaged. p1 This is a high priority issue p2 This is a standard priority issue labels May 15, 2024
@kuhe
Copy link
Contributor

kuhe commented May 15, 2024

I have confirmed the issue. I have temporarily marked @aws-sdk/[email protected] as latest on NPM to mitigate.
As of now, the installation command should work.

We intend to release a patch for this later today.

@trivikr
Copy link
Member

trivikr commented May 15, 2024

Reopening to verify fix after https://github.com/aws/aws-sdk-js-v3/releases/tag/v3.577.0 is published, which is expected around 12:30 PM Pacific today.

@trivikr trivikr reopened this May 15, 2024
@trivikr
Copy link
Member

trivikr commented May 15, 2024

verify fix after v3.577.0 (release) is published

The v3.577.0 is published, and there's no failures with npm install anymore

$ npm i @aws-sdk/client-secrets-manager @aws-sdk/client-sts

$ npm ls @aws-sdk/client-sts
[email protected] /Users/trivikr/workspace/test-npm
├─┬ @aws-sdk/[email protected]
│ ├─┬ @aws-sdk/[email protected]
│ │ └── @aws-sdk/[email protected] deduped
│ ├── @aws-sdk/[email protected] deduped
│ └─┬ @aws-sdk/[email protected]
│   ├─┬ @aws-sdk/[email protected]
│   │ └── @aws-sdk/[email protected] deduped
│   └─┬ @aws-sdk/[email protected]
│     └── @aws-sdk/[email protected] deduped
└── @aws-sdk/[email protected]

$ grep peerDependencies -A 2 node_modules/@aws-sdk/credential-provider-ini/package.json 
  "peerDependencies": {
    "@aws-sdk/client-sts": "^3.577.0"
  },

@trivikr trivikr closed this as completed May 15, 2024
@Callenowy
Copy link
Author

Beautiful, thank You! :)

Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. p1 This is a high priority issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants