(lib-dynamodb): DocumentClient should handle i/o of large numbers e.g. BigInt

[alanb-sony]

Checkboxes for prior research

• I've gone through Developer Guide and API reference
• I've checked AWS Forums and StackOverflow.
• I've searched for previous similar issues and didn't find any solution.

Describe the bug

The following code:

const doc = DynamoDBDocument.from(new DynamoDB());
await doc.put({
  TableName: 'test',
  Item: { num: 1.23e100 },
});

Raises the error:

Error: Number 1.23e+100 is greater than Number.MAX_SAFE_INTEGER. Use BigInt.

We could change num to BigInt but it is actually a floating point value so we'd have to only convert large numbers, as our numbers are already stored as Number, changing them to BigInt isn't going to increase their precision

SDK version number

@aws-sdk/[email protected]

Which JavaScript Runtime is this issue in?

Node.js

Details of the browser/Node.js/ReactNative version

v18.18.0

Reproduction Steps

const doc = DynamoDBDocument.from(new DynamoDB());
await doc.put({
  TableName: 'test',
  Item: { num: 1.23e100 },
});

Observed Behavior

An error is thrown:

Error: Number 1.23e+100 is greater than Number.MAX_SAFE_INTEGER. Use BigInt.

Expected Behavior

Large numbers should be stored in the database

Possible Solution

No response

Additional Information/Context

No response

[alanb-sony]

Even converting a number to a BigInt isn't a trivial task as dynamo wont accept numbers with more than 38 digits of precision

[kuhe]

For now, use the base DynamoDB client to put with large numbers.

[kuhe]

A way to mark large or precise numbers for input and output will be included in the next release.

Instructions are at #5427 or https://github.com/aws/aws-sdk-js-v3/blob/main/lib/lib-dynamodb/README.md#large-numbers-and-numbervalue

[alanb-sony]

This seems an odd solution to me? We can't construct NumberValue from a number so we have to do NumberValue.from(num.toString())?

I'm still not sure what the reasoning behind restricting the range of numbers is?

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.