Undeclared @smithy/smithy-client dependency in @aws-sdk/credential-provider-http

[Drarig29]

Checkboxes for prior research

• I've gone through Developer Guide and API reference
• I've checked AWS Forums and StackOverflow.
• I've searched for previous similar issues and didn't find any solution.

Describe the bug

Same as #5056

The @smithy/smithy-client dependency is imported here:

aws-sdk-js-v3/packages/credential-provider-http/src/fromHttp/requestHelpers.ts

Line 4 in f05d9c6

import { parseRfc3339DateTime } from "@smithy/smithy-client";

But not declared in @aws-sdk/credential-provider-http's dependencies.

SDK version number

@aws-sdk/[email protected], @aws-sdk/[email protected]

Which JavaScript Runtime is this issue in?

Node.js

Details of the browser/Node.js/ReactNative version

v18.15.0

Reproduction Steps

• yarn add @aws-sdk/[email protected]
• import {fromIni} from '@aws-sdk/credential-providers'

Observed Behavior

At import time, Node.js fails with:

Error: @aws-sdk/credential-provider-http tried to access @smithy/smithy-client, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

Required package: @smithy/smithy-client
Required by: @aws-sdk/credential-provider-http@npm:3.428.0 (via <redacted>/.yarn/cache/@aws-sdk-credential-provider-http-npm-3.428.0-193a49487e-e0824af9d4.zip/node_modules/@aws-sdk/credential-provider-http/dist-cjs/fromHttp/)

Expected Behavior

The code should run without import time errors.

Possible Solution

No response

Additional Information/Context

No response

[yenfryherrerafeliz]

Hi @Drarig29, this has been fixed. Please just update to the latest version and you should have not issues. You can confirm the fix here.

Please feel free of opening a new issue if is there anything that we can help you with.

Thanks!

[jfirebaugh]

@yenfryherrerafeliz It isn't fixed in the latest version. The line you linked to is a dependency on @smithy/types, not @smithy/smithy-client. Could you please reopen the issue?

[Drarig29]

@yenfryherrerafeliz I agree with John that the issue is not fixed, and that the line you linked isn't related.

Can you please reopen?

[Drarig29]

Pinging @kuhe since you recently fixed a related issue 🙂

[kuhe]

Added it in #5395 to be included in the next release.

[Drarig29]

Thanks a lot!

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.