Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn generate:defaults-mode-provider fails if smithy-typescript is not built #5141

Closed
3 tasks done
trivikr opened this issue Aug 24, 2023 · 4 comments
Closed
3 tasks done
Labels
bug This issue is a bug. closed-for-staleness p2 This is a standard priority issue queued This issues is on the AWS team's backlog

Comments

@trivikr
Copy link
Member

trivikr commented Aug 24, 2023

Checkboxes for prior research

Describe the bug

This issue was noticed while testing our release automation after merging #5139

SDK version number

main

Which JavaScript Runtime is this issue in?

Node.js

Details of the browser/Node.js/ReactNative version

N/A

Reproduction Steps

Remove maven cache, and run yarn generate:defaults-mode-provider

$ rm -rf ~/.m2/repository

$ yarn generate:defaults-mode-provider

Observed Behavior

Command fails with cannot find symbol with 31 counts.

  symbol:   method settingsPredicate((m,s,setti[...]uth())
  location: class Builder
/local/home/trivikr/workspace/aws-sdk-js-v3/codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AddTokenAuthPlugin.java:44: error: cannot find symbol
                    .settingsPredicate((m, s, settings) -> !settings.getExperimentalIdentityAndAuth())
                    ^
  symbol:   method settingsPredicate((m,s,setti[...]uth())
  location: class Builder
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
31 errors

FAILURE: Build failed with an exception.

Expected Behavior

The generate:defaults-mode-provider command to succeed.

Possible Solution

Build smithy-typescript with HEAD before generating default-mode-provider

Additional Information/Context

No response

@trivikr trivikr added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. p2 This is a standard priority issue queued This issues is on the AWS team's backlog and removed needs-triage This issue or PR still needs to be triaged. labels Aug 24, 2023
@trivikr
Copy link
Member Author

trivikr commented Aug 24, 2023

ToDo on aws-sdk:

  • Finalize the package name where JS code defaults-mode.ts should be generated, and made changes so that AWS SDK clients read from it.
  • Decouple DefaultsModeConfigGenerator from smithy-typescript, so that it can be run independently.
  • Update generate:defaults-mode-provider to ensure it updates the new location.

Action items from smithy-lang/smithy-typescript#895 (comment)

@trivikr
Copy link
Member Author

trivikr commented Aug 24, 2023

The DefaultsModeConfigGenerator only uses TypeScriptWriter from smithy-typescript.
It can depend on remote version of smithy-typescript, for the purpose of generating defaults-mode.ts.

Copy link

Greetings! We’re closing this issue because it has been open a long time and hasn’t been updated in a while and may not be getting the attention it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to comment or open a new issue.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Sep 27, 2024
@github-actions github-actions bot closed this as completed Oct 2, 2024
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. closed-for-staleness p2 This is a standard priority issue queued This issues is on the AWS team's backlog
Projects
None yet
Development

No branches or pull requests

1 participant