Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip downleveling of packages inside private folder #4912

Closed
2 tasks
trivikr opened this issue Jul 3, 2023 · 1 comment · Fixed by #4914
Closed
2 tasks

Skip downleveling of packages inside private folder #4912

trivikr opened this issue Jul 3, 2023 · 1 comment · Fixed by #4914
Labels
feature-request New feature or enhancement. May require GitHub community feedback. needs-triage This issue or PR still needs to be triaged.

Comments

@trivikr
Copy link
Member

trivikr commented Jul 3, 2023

Describe the feature

Skip downleveling of packages inside private folder, as they're not published.

Use Case

The scripts/downlevel-dts script failed in preview builds, when aws-middleware-test package was added.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

SDK version used

main

Environment details (OS name and version, etc.)

N/A
@trivikr trivikr added feature-request New feature or enhancement. May require GitHub community feedback. needs-triage This issue or PR still needs to be triaged. labels Jul 3, 2023
This was referenced Jul 3, 2023
Merged
Merged
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature-request New feature or enhancement. May require GitHub community feedback. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(scripts): skip downleveling of packages in private folder trivikr/aws-sdk-js-v3
1 participant
@trivikr