Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib-storage): fix typo in Upload.intialize (initialize) #2025

Merged
merged 2 commits into from
Feb 17, 2021

Conversation

TysonAndre
Copy link
Contributor

Keep the old name for now?

The name was introduced in b07e719
when the file was added

Issue

Description

Fix typo in a method name

Testing

TODO

Additional context


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Keep the old name for now?

The name was introduced in b07e719
when the file was added
@trivikr trivikr changed the title fix(storage) fix typo in Upload.intialize (initialize) fix(lib-storage): fix typo in Upload.intialize (initialize) Feb 11, 2021
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 95a3943
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-io
Copy link

Codecov Report

Merging #2025 (95a3943) into master (f2a47e8) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2025      +/-   ##
==========================================
+ Coverage   79.30%   79.35%   +0.04%     
==========================================
  Files         368      368              
  Lines       15132    15199      +67     
  Branches     3222     3254      +32     
==========================================
+ Hits        12001    12061      +60     
- Misses       3131     3138       +7     
Impacted Files Coverage Δ
packages/util-waiter/src/utils/validate.ts 81.81% <0.00%> (-18.19%) ⬇️
...process-arnables-plugin/update-arnables-request.ts 91.30% <0.00%> (-8.70%) ⬇️
lib/storage/src/data-chunk/readable-helper.ts 86.84% <0.00%> (-5.47%) ⬇️
packages/s3-request-presigner/src/presigner.ts 94.73% <0.00%> (-5.27%) ⬇️
...s/middleware-bucket-endpoint/src/bucketHostname.ts 98.27% <0.00%> (-1.73%) ⬇️
packages/util-dynamodb/src/convertToAttr.ts 98.82% <0.00%> (-1.18%) ⬇️
packages/util-waiter/src/poller.ts 100.00% <0.00%> (ø)
packages/util-waiter/src/waiter.ts 100.00% <0.00%> (ø)
protocol_tests/aws-ec2/endpoints.ts 81.48% <0.00%> (ø)
protocol_tests/aws-json/endpoints.ts 81.48% <0.00%> (ø)
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1c548e...95a3943. Read the comment docs.

@alexforsyth
Copy link
Contributor

@TysonAndre Thanks so much for this PR! I'll merge this (yay a new contributor!), but it will be overwritten by #2039

Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@alexforsyth alexforsyth merged commit 16214be into aws:master Feb 17, 2021
@github-actions
Copy link

github-actions bot commented Mar 4, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants