Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(util-user-agent-browser): use default import from bowser #1991

Merged
merged 2 commits into from
Feb 4, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Feb 2, 2021

Issue

Fixes: #1992

Description

Uses default import from bowser as suggested in README https://github.com/lancedikson/bowser#use-cases

Testing

Verified that snowpack build is successful and todo-app works after performing:

  • yarn local-publish to publish packages from workspace using verdaccio.
  • ./node_modules/.bin/verdaccio -c verdaccio/config.yaml to start verdaccio server.
  • Use published version "3.4.2-ci.0" in todo-app with snowpack.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from AllanZhengYP February 2, 2021 01:03
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: bf9467f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-io
Copy link

Codecov Report

Merging #1991 (bf9467f) into master (f2a47e8) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1991      +/-   ##
==========================================
+ Coverage   79.30%   79.34%   +0.04%     
==========================================
  Files         368      368              
  Lines       15132    15171      +39     
  Branches     3222     3242      +20     
==========================================
+ Hits        12001    12038      +37     
- Misses       3131     3133       +2     
Impacted Files Coverage Δ
packages/util-waiter/src/utils/validate.ts 81.81% <0.00%> (-18.19%) ⬇️
lib/storage/src/data-chunk/readable-helper.ts 86.84% <0.00%> (-5.47%) ⬇️
packages/util-dynamodb/src/convertToAttr.ts 98.71% <0.00%> (-1.29%) ⬇️
packages/util-waiter/src/poller.ts 100.00% <0.00%> (ø)
packages/util-waiter/src/waiter.ts 100.00% <0.00%> (ø)
protocol_tests/aws-ec2/endpoints.ts 81.48% <0.00%> (ø)
protocol_tests/aws-json/endpoints.ts 81.48% <0.00%> (ø)
packages/middleware-ssec/src/index.ts 82.60% <0.00%> (ø)
protocol_tests/aws-query/endpoints.ts 81.48% <0.00%> (ø)
packages/util-dynamodb/src/marshall.ts 100.00% <0.00%> (ø)
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa33f0b...bf9467f. Read the comment docs.

Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thank you!

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build error "'parse' is not exported by node_modules/bowser/src/bowser.js" with snowpack
4 participants