-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(util-user-agent-browser): use default import from bowser #1991
Conversation
Reason: esModuleInterop is enabled in tsconfig. Refs: bowser-js/bowser#284
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Codecov Report
@@ Coverage Diff @@
## master #1991 +/- ##
==========================================
+ Coverage 79.30% 79.34% +0.04%
==========================================
Files 368 368
Lines 15132 15171 +39
Branches 3222 3242 +20
==========================================
+ Hits 12001 12038 +37
- Misses 3131 3133 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! Thank you!
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue
Fixes: #1992
Description
Uses default import from bowser as suggested in README https://github.com/lancedikson/bowser#use-cases
Testing
Verified that snowpack build is successful and todo-app works after performing:
yarn local-publish
to publish packages from workspace using verdaccio../node_modules/.bin/verdaccio -c verdaccio/config.yaml
to start verdaccio server."3.4.2-ci.0"
in todo-app with snowpack.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.