fix: allow packages/types in gitignore #1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitignore ignores packages/types in addition to types folders for type definitions husky > pre-commit (node v14.15.4) ✔ Preparing... ✔ Running tasks... ✖ The following paths are ignored by one of your .gitignore files: packages/types Use -f if you really want to add them. ✔ Cleaning up... husky > commit-msg (node v14.15.4)
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Codecov Report
@@ Coverage Diff @@
## master #1942 +/- ##
==========================================
+ Coverage 79.30% 79.83% +0.52%
==========================================
Files 368 368
Lines 15132 15553 +421
Branches 3222 3368 +146
==========================================
+ Hits 12001 12417 +416
- Misses 3131 3136 +5
Continue to review full report at Codecov.
|
alexforsyth
reviewed
Jan 21, 2021
alexforsyth
approved these changes
Jan 21, 2021
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Follow-up to #1938
Description of changes:
gitignore ignores packages/types in addition to types folders used for type definitions
This PR skips packages/types from gitignore.
Verified that:
packages/types/typespackages/types, like inpackage.jsonBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.