Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(generate-clients): call mergeManifest when constructor.name is Object #1937

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jan 21, 2021

Issue #, if available:
Refs: #1919 (comment)

Description of changes:
In #1919, we decided to use downlevel-dts to create type definition files which support TS 3.4 or later. The configuration for typesVersions contains an array which is replaced to an object by out copy-to-clients script as it returns true for typeof operation.

This PR changes the typeof check to constructor.name so that only objects are replaced in package.json

$ node
Welcome to Node.js v14.15.4.
Type ".help" for more information.
> const arr = ["arr"];
undefined
> typeof arr
'object'
> arr.constructor.name
'Array'
> const obj = {"obj": "obj"};
undefined
> typeof obj
'object'
> obj.constructor.name
'Object'
> const str = "str";
undefined
> typeof str
'string'
> str.constructor.name
'String'

Testing:
Verified that generate-clients doesn't update any package.json because of this change.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: beafa0e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-io
Copy link

Codecov Report

Merging #1937 (beafa0e) into master (f2a47e8) will increase coverage by 0.52%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1937      +/-   ##
==========================================
+ Coverage   79.30%   79.83%   +0.52%     
==========================================
  Files         368      368              
  Lines       15132    15553     +421     
  Branches     3222     3368     +146     
==========================================
+ Hits        12001    12417     +416     
- Misses       3131     3136       +5     
Impacted Files Coverage Δ
packages/util-waiter/src/utils/validate.ts 81.81% <0.00%> (-18.19%) ⬇️
lib/storage/src/data-chunk/readable-helper.ts 86.84% <0.00%> (-5.47%) ⬇️
packages/s3-request-presigner/src/getSignedUrl.ts 92.85% <0.00%> (-2.98%) ⬇️
packages/util-dynamodb/src/convertToAttr.ts 98.70% <0.00%> (-1.30%) ⬇️
packages/util-waiter/src/poller.ts 100.00% <0.00%> (ø)
packages/util-waiter/src/waiter.ts 100.00% <0.00%> (ø)
protocol_tests/aws-ec2/endpoints.ts 81.48% <0.00%> (ø)
protocol_tests/aws-json/endpoints.ts 81.48% <0.00%> (ø)
protocol_tests/aws-query/endpoints.ts 81.48% <0.00%> (ø)
packages/util-dynamodb/src/marshall.ts 100.00% <0.00%> (ø)
... and 156 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e11909b...beafa0e. Read the comment docs.

Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexforsyth alexforsyth merged commit 601c03b into master Jan 21, 2021
alexforsyth added a commit that referenced this pull request Jan 21, 2021
@trivikr trivikr deleted the generate-clients-fix branch January 21, 2021 16:33
@github-actions
Copy link

github-actions bot commented Feb 5, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants