Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(url-parser): merge browser and node url parser, add rn url parser #1903

Merged
merged 4 commits into from
Jan 14, 2021

Conversation

AllanZhengYP
Copy link
Contributor

Fixes #1867, #1900

Both @aws-sdk/url-parser-node and @aws-sdk/url-parser-browser use WHATWG URL()
to parse the url. In fact their code are identical. So they are deprecated and
replaced by @aws-sdk/url-parser.

However, URL() is not supported in React Native. So we need to use parse()
from "url" package. @aws-sdk/url-parser-native is used in React Native runtime.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Given both browsers and Node10 support global WHATWG URL(), so merge them
to the same package.
@codecov-io
Copy link

Codecov Report

Merging #1903 (3075297) into master (f2a47e8) will increase coverage by 0.52%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1903      +/-   ##
==========================================
+ Coverage   79.30%   79.83%   +0.52%     
==========================================
  Files         368      368              
  Lines       15132    15552     +420     
  Branches     3222     3367     +145     
==========================================
+ Hits        12001    12416     +415     
- Misses       3131     3136       +5     
Impacted Files Coverage Δ
packages/util-waiter/src/utils/validate.ts 81.81% <0.00%> (-18.19%) ⬇️
lib/storage/src/data-chunk/readable-helper.ts 86.84% <0.00%> (-5.47%) ⬇️
packages/s3-request-presigner/src/getSignedUrl.ts 92.85% <0.00%> (-2.98%) ⬇️
packages/util-dynamodb/src/convertToAttr.ts 98.70% <0.00%> (-1.30%) ⬇️
packages/util-waiter/src/waiter.ts 100.00% <0.00%> (ø)
protocol_tests/aws-ec2/endpoints.ts 81.48% <0.00%> (ø)
protocol_tests/aws-json/endpoints.ts 81.48% <0.00%> (ø)
protocol_tests/aws-query/endpoints.ts 81.48% <0.00%> (ø)
packages/util-dynamodb/src/marshall.ts 100.00% <0.00%> (ø)
protocol_tests/aws-ec2/runtimeConfig.ts 100.00% <0.00%> (ø)
... and 155 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96f1087...3075297. Read the comment docs.

@AllanZhengYP AllanZhengYP marked this pull request as ready for review January 13, 2021 23:13
@AllanZhengYP
Copy link
Contributor Author

AllanZhengYP commented Jan 13, 2021

@trivikr Confirmed that the issue is solved in simulator.

Screen Shot

simulator_screenshot_DEB32429-0BF6-4656-A565-85E226DAD309

@AllanZhengYP AllanZhengYP requested a review from trivikr January 13, 2021 23:14
Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Changelog below the title packages/url-parser/CHANGELOG.md should be removed, as it's a new package.

The package name in packages/url-parser/README.md title and npm badges needs to be updated.

packages/url-parser/package.json Show resolved Hide resolved
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 18a8ba8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@AllanZhengYP AllanZhengYP merged commit 99be092 into aws:master Jan 14, 2021
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Error: not implemented" in React Native environment
4 participants