-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(url-parser): merge browser and node url parser, add rn url parser #1903
Conversation
Given both browsers and Node10 support global WHATWG URL(), so merge them to the same package.
Codecov Report
@@ Coverage Diff @@
## master #1903 +/- ##
==========================================
+ Coverage 79.30% 79.83% +0.52%
==========================================
Files 368 368
Lines 15132 15552 +420
Branches 3222 3367 +145
==========================================
+ Hits 12001 12416 +415
- Misses 3131 3136 +5
Continue to review full report at Codecov.
|
@trivikr Confirmed that the issue is solved in simulator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Changelog below the title packages/url-parser/CHANGELOG.md
should be removed, as it's a new package.
The package name in packages/url-parser/README.md
title and npm badges needs to be updated.
3075297
to
18a8ba8
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Fixes #1867, #1900
Both
@aws-sdk/url-parser-node
and@aws-sdk/url-parser-browser
use WHATWGURL()
to parse the url. In fact their code are identical. So they are deprecated and
replaced by
@aws-sdk/url-parser
.However,
URL()
is not supported in React Native. So we need to useparse()
from "url" package.
@aws-sdk/url-parser-native
is used in React Native runtime.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.