fix(clients): lowercase all header names in serializer #1892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
previously approved these changes
Jan 8, 2021
Codecov Report
@@ Coverage Diff @@
## master #1892 +/- ##
==========================================
+ Coverage 79.30% 79.83% +0.52%
==========================================
Files 368 368
Lines 15132 15543 +411
Branches 3222 3364 +142
==========================================
+ Hits 12001 12409 +408
- Misses 3131 3134 +3
Continue to review full report at Codecov.
|
trivikr
dismissed
their stale review
CI failed, protocol_tests need to be updated
The HTTP request class doesn't have any implementations to insure case-insensitivity of the http headers. So we need to be mindful when populating these headers. Otherwise, the reqeust signature will be messed up. This change will ensure the protocol-specific default headers like content-type will be overriden by the serialized header if exists. For other headers added through middleware stack either by customization or users, it wouldn't affect signing or sending as long as the request doesn't contain same header names in different casing. All the internal headers will be consistent. But users should be careful when they are adding their own headers. We don't add middleware to lowercase all headers to prevent alternating the users' customizations. Ref: aws#1800
AllanZhengYP
force-pushed
the
fix-content-type
branch
from
a6d4ba6 to
9407d5e
Compare
AllanZhengYP
force-pushed
the
fix-content-type
branch
from
9407d5e to
657c5c2
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
trivikr
approved these changes
Jan 12, 2021
|
Integration test is confirmed to pass: yarn test:integration-legacy
yarn run v1.22.5
$ cucumber-js --fail-fast
........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
152 scenarios (152 passed)
528 steps (528 passed)
2m57.222s
Done in 181.85s./cc @kstich |
kstich
approved these changes
Jan 13, 2021
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HTTP request class doesn't have any implementations to insure
case-insensitivity of the http headers. So we need to be mindful
when populating these headers. Otherwise, the reqeust signature
will be messed up. This change will ensure the protocol-specific
default headers like content-type will be overriden by the serialized
header if exists.
For other headers added through middleware stack either by
customization or users, it wouldn't affect signing or sending as long
as the request doesn't contain same header names in different casing.
All the internal headers will be consistent. But users should be
careful when they are adding their own headers.
We don't add middleware to lowercase all headers to prevent
alternating the users' customizations.
Fixes: #1800
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.