Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(util-dynamodb): enable undefined values removal in marshall #1840

Merged
merged 6 commits into from
Dec 24, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Dec 23, 2020

Issue #, if available:
Fixes: #1816

Description of changes:
Enables removal of undefined values in marshall by setting removeUndefinedValues=true

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

Codecov Report

Merging #1840 (6f79f56) into master (f2a47e8) will increase coverage by 0.01%.
The diff coverage is 95.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1840      +/-   ##
==========================================
+ Coverage   79.30%   79.32%   +0.01%     
==========================================
  Files         368      368              
  Lines       15132    15147      +15     
  Branches     3222     3231       +9     
==========================================
+ Hits        12001    12015      +14     
- Misses       3131     3132       +1     
Impacted Files Coverage Δ
packages/util-dynamodb/src/marshall.ts 100.00% <ø> (ø)
packages/util-waiter/src/waiter.ts 100.00% <ø> (ø)
...middleware-user-agent/src/user-agent-middleware.ts 93.10% <66.66%> (ø)
packages/util-dynamodb/src/convertToAttr.ts 98.70% <100.00%> (-1.30%) ⬇️
packages/util-waiter/src/createWaiter.ts 100.00% <100.00%> (+11.76%) ⬆️
packages/util-waiter/src/poller.ts 100.00% <100.00%> (ø)
packages/util-waiter/src/utils/validate.ts 100.00% <100.00%> (ø)
protocol_tests/aws-json/endpoints.ts 81.48% <100.00%> (ø)
lib/storage/src/data-chunk/readable-helper.ts 88.23% <0.00%> (-4.08%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca1f0d6...6f79f56. Read the comment docs.

@trivikr trivikr requested a review from AllanZhengYP December 23, 2020 22:32
@trivikr trivikr changed the title feat(util-dynamodb): enable removal of undefined values in marshall feat(util-dynamodb): enable undefined values removal in marshall Dec 24, 2020
@trivikr trivikr merged commit 314d3b3 into aws:master Dec 24, 2020
@trivikr trivikr deleted the util-dynamodb-undefined branch December 24, 2020 05:00
@github-actions
Copy link

github-actions bot commented Jan 8, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DynamoDB Marshaller does not handle undefined property values
3 participants