-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(clients): default region and credential provider #1834
fix(clients): default region and credential provider #1834
Conversation
a222876
to
4a8c898
Compare
Codecov Report
@@ Coverage Diff @@
## master #1834 +/- ##
==========================================
+ Coverage 79.30% 79.31% +0.01%
==========================================
Files 368 368
Lines 15132 15140 +8
Branches 3222 3226 +4
==========================================
+ Hits 12001 12009 +8
Misses 3131 3131
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
4a8c898
to
9a47d48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix verified in browser using aws-sdk-js-tests
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
This change makes default credential only resolves at signer signing a request. So that it won't resolve at client instantiation. It fixes the issues that the default credentials provider resolves when credentials is not required for given operations, like
CognitoIdentity.getId()
.Fixes: #1798
Example stack trace for missing credentials in browsers:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.