-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(signature-v4): add secrets to signing key cache key #1776
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1776 +/- ##
==========================================
- Coverage 79.77% 79.28% -0.50%
==========================================
Files 325 367 +42
Lines 12087 15116 +3029
Branches 2553 3221 +668
==========================================
+ Hits 9643 11985 +2342
- Misses 2444 3131 +687
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Added some nit for unit tests
d42efa0
to
0dc9971
Compare
Rebase it to pass the Java test |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Fixes #1002
Description of changes:
This change fix the issue that signing key is not refreshed between requests with only different secret access keys. I added a hash of both access key id and secrete access key as the cache key is signing keys.
However, previously we cached pending promise of signing keys, but now we only cache the resolved promise of signing keys. So it's safer but may have wild performance implication. We can optimize this after we have benchmark metrics of this module.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.