Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update clients as of 11/13 #1676

Merged
merged 7 commits into from
Nov 13, 2020
Merged

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Nov 12, 2020

Issue #, if available:
Draft PR for testing copy-models script #1675

Description of changes:
update clients as of 11/11

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

codecov-io commented Nov 12, 2020

Codecov Report

Merging #1676 (b62673c) into master (de75f7e) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1676      +/-   ##
==========================================
- Coverage   79.77%   79.71%   -0.07%     
==========================================
  Files         325      328       +3     
  Lines       12087    12573     +486     
  Branches     2553     2670     +117     
==========================================
+ Hits         9643    10022     +379     
- Misses       2444     2551     +107     
Impacted Files Coverage Δ
...tocol_tests/aws-restxml/commands/XmlMapsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ocol_tests/aws-restxml/commands/XmlBlobsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ocol_tests/aws-restxml/commands/XmlEnumsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ocol_tests/aws-restxml/commands/XmlListsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...col_tests/aws-restjson/commands/JsonMapsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ol_tests/aws-restjson/commands/JsonBlobsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ol_tests/aws-restjson/commands/JsonEnumsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ol_tests/aws-restjson/commands/JsonListsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...tests/aws-restxml/commands/XmlAttributesCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...tests/aws-restxml/commands/XmlNamespacesCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
... and 100 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 028a362...6e0fa28. Read the comment docs.

@trivikr trivikr force-pushed the update-models-11/11 branch from 7f7e767 to b62673c Compare November 12, 2020 23:29
@trivikr trivikr changed the title feat: update clients as of 11/11 feat: update clients as of 11/12 Nov 13, 2020
@trivikr trivikr marked this pull request as ready for review November 13, 2020 18:08
@trivikr trivikr requested a review from alexforsyth November 13, 2020 18:50
Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it revert the changes from #1667?

@trivikr
Copy link
Member Author

trivikr commented Nov 13, 2020

Does it revert the changes from #1667?

Yes. And a good catch! 👍

The smithy-typescript package wasn't updated when this codegen was run.
I'll update in a commit, and also update models from 11/13.

@trivikr trivikr changed the title feat: update clients as of 11/12 feat: update clients as of 11/13 Nov 13, 2020
@trivikr trivikr requested a review from AllanZhengYP November 13, 2020 20:08
@trivikr trivikr merged commit 2d934c9 into aws:master Nov 13, 2020
@trivikr trivikr deleted the update-models-11/11 branch November 13, 2020 20:34
@AllanZhengYP
Copy link
Contributor

This one contains a lot of changes that just reorders the code blocks. Created a bug report to track it: #1683

@github-actions
Copy link

github-actions bot commented Jan 9, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants