Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codegen): add script to copy models from local directory #1675

Merged
merged 4 commits into from
Nov 12, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Nov 12, 2020

Issue #, if available:
Internal JS-2184

Description of changes:
Adds script to copy models from local directory.

$ yarn copy-models
yarn run v1.22.5
$ node ./scripts/copy-models
Options:
  --version     Show version number                                    [boolean]
  -m, --models  The path to directory with aws-models.       [string] [required]
  --help        Show help                                              [boolean]

Missing required argument: models
error Command failed with exit code 1.

$ yarn copy-models -m ~/workspace/updated-models
...

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr
Copy link
Member Author

trivikr commented Nov 12, 2020

Example clients update can be viewed at #1676

@trivikr trivikr changed the title feat(codegen): copy models from local directory feat(codegen): add script to copy models from local directory Nov 12, 2020
Reason: it's shared between copy-modles and generate-clients scripts
@codecov-io
Copy link

codecov-io commented Nov 12, 2020

Codecov Report

Merging #1675 (0528f99) into master (de75f7e) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1675      +/-   ##
==========================================
- Coverage   79.77%   79.71%   -0.07%     
==========================================
  Files         325      328       +3     
  Lines       12087    12573     +486     
  Branches     2553     2670     +117     
==========================================
+ Hits         9643    10022     +379     
- Misses       2444     2551     +107     
Impacted Files Coverage Δ
...tocol_tests/aws-restxml/commands/XmlMapsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ocol_tests/aws-restxml/commands/XmlBlobsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ocol_tests/aws-restxml/commands/XmlEnumsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ocol_tests/aws-restxml/commands/XmlListsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...col_tests/aws-restjson/commands/JsonMapsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ol_tests/aws-restjson/commands/JsonBlobsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ol_tests/aws-restjson/commands/JsonEnumsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ol_tests/aws-restjson/commands/JsonListsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...tests/aws-restxml/commands/XmlAttributesCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...tests/aws-restxml/commands/XmlNamespacesCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
... and 100 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3fab9f...0528f99. Read the comment docs.

@trivikr trivikr requested a review from AllanZhengYP November 12, 2020 18:09
@trivikr trivikr merged commit 028a362 into aws:master Nov 12, 2020
@trivikr trivikr deleted the copy-models-script branch November 12, 2020 23:06
@github-actions
Copy link

github-actions bot commented Jan 9, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants