Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not publish new version of a package if only change is dependency version which follows semver range #1042

Closed
trivikr opened this issue Mar 24, 2020 · 2 comments
Labels
CI/CD This is related to CI/CD feature-request New feature or enhancement. May require GitHub community feedback.

Comments

@trivikr
Copy link
Member

trivikr commented Mar 24, 2020

Is your feature request related to a problem? Please describe.
A new version of a package is published even if the only change is dependency update which follows semver range:

Example releases for @aws-sdk/abort-controller where only changes are dependencies:

  • v1.0.0-alpha.2
    • The only change is dependency update from @aws-sdk/types@^1.0.0-alpha.2 to @aws-sdk/types@^1.0.0-alpha.3
  • v1.0.0-alpha.3
    • The only change is dependency update from @aws-sdk/types@^1.0.0-alpha.3 to @aws-sdk/types@^1.0.0-alpha.4
  • v1.0.0-alpha.4
    • The only change is dependency update from @aws-sdk/types@^1.0.0-alpha.4 to @aws-sdk/types@^1.0.0-alpha.5

Describe the solution you'd like

  • [Preferred to minimize dependency updates] Do not update package dependency version, if the new version follows semver range
  • [Backup] Do not publish a new version of package, if the only change is update in dependency version which follows semver range

Describe alternatives you've considered
Continue to publish new versions, and manage those every increasing version numbers

@trivikr trivikr added feature-request New feature or enhancement. May require GitHub community feedback. CI/CD This is related to CI/CD labels Mar 24, 2020
@trivikr
Copy link
Member Author

trivikr commented Jan 6, 2021

This issue was fixed after moving to lerna fixed versioning in #1577

@trivikr trivikr closed this as completed Jan 6, 2021
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI/CD This is related to CI/CD feature-request New feature or enhancement. May require GitHub community feedback.
Projects
None yet
Development

No branches or pull requests

1 participant