From 8c78d7e848ce455bd9a0d67b0969c6f20e1d77ac Mon Sep 17 00:00:00 2001 From: "Kamat, Trivikram" <16024985+trivikr@users.noreply.github.com> Date: Sun, 28 Jul 2024 15:21:41 -0700 Subject: [PATCH] chore: remove type assertion in addNamedModule --- .../v2-to-v3/modules/requireModule/addNamedModule.ts | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/src/transforms/v2-to-v3/modules/requireModule/addNamedModule.ts b/src/transforms/v2-to-v3/modules/requireModule/addNamedModule.ts index c29e03363..d0551565b 100644 --- a/src/transforms/v2-to-v3/modules/requireModule/addNamedModule.ts +++ b/src/transforms/v2-to-v3/modules/requireModule/addNamedModule.ts @@ -1,6 +1,6 @@ -import type { Collection, JSCodeshift, ObjectPattern, ObjectProperty, Property } from "jscodeshift"; +import type { Collection, JSCodeshift, ObjectPattern } from "jscodeshift"; -import { OBJECT_PROPERTY_TYPE_LIST, PACKAGE_NAME } from "../../config"; +import { PACKAGE_NAME } from "../../config"; import { objectPatternPropertyCompareFn } from "../objectPatternPropertyCompareFn"; import { getRequireDeclarators } from "../requireModule"; import type { ModulesOptions } from "../types"; @@ -30,13 +30,11 @@ export const addNamedModule = ( (variableDeclarator) => variableDeclarator.id.type === "ObjectPattern" && variableDeclarator.id.properties.find((property) => { - if (!OBJECT_PROPERTY_TYPE_LIST.includes(property.type)) return false; - const key = (property as Property | ObjectProperty).key; - const value = (property as Property | ObjectProperty).value; - if (key.type !== "Identifier" || value.type !== "Identifier") { + if (property.type !== "Property" && property.type !== "ObjectProperty") return false; + if (property.key.type !== "Identifier" || property.value.type !== "Identifier") { return false; } - return key.name === importedName && value.name === localName; + return property.key.name === importedName && property.value.name === localName; }) ) ) {