From 2507722ee1cb2269df292d41ba98464d6900989e Mon Sep 17 00:00:00 2001 From: Shiva Kumar Mukkapati Date: Thu, 1 Feb 2024 19:14:06 -0500 Subject: [PATCH 1/7] including S3 Access Grants Plugin as part of Java SDK Bundle --- aws-sdk-java/pom.xml | 6 ++++++ bundle-sdk/pom.xml | 2 ++ pom.xml | 3 +++ 3 files changed, 11 insertions(+) diff --git a/aws-sdk-java/pom.xml b/aws-sdk-java/pom.xml index ea562dec7d7a..092e292d3ffe 100644 --- a/aws-sdk-java/pom.xml +++ b/aws-sdk-java/pom.xml @@ -728,6 +728,11 @@ Amazon AutoScaling, etc). s3control ${awsjavasdk.version} + + software.amazon.s3.accessgrants + aws-s3-accessgrants-java-plugin + ${s3accessgrants.version} + software.amazon.awssdk s3-transfer-manager @@ -1923,6 +1928,7 @@ Amazon AutoScaling, etc). software.amazon.awssdk:* + software.amazon.s3.accessgrants:* diff --git a/bundle-sdk/pom.xml b/bundle-sdk/pom.xml index 6d3cb33f46b5..7eec4ec89441 100644 --- a/bundle-sdk/pom.xml +++ b/bundle-sdk/pom.xml @@ -76,6 +76,8 @@ commons-codec:commons-codec software.amazon.awssdk:* software.amazon:* + software.amazon.s3.accessgrants:* + com.github.benmanes.caffeine:* commons-logging:* diff --git a/pom.xml b/pom.xml index 2bcc54a152df..e496beaafa23 100644 --- a/pom.xml +++ b/pom.xml @@ -177,6 +177,9 @@ 1.0.4 + + 2.0.0 + ${skipTests} ${project.basedir}/src/it/java ${session.executionRootDirectory} From 005a914f8f6b27e0d6a433ca852a920d8aa5f137 Mon Sep 17 00:00:00 2001 From: Shiva Kumar Mukkapati Date: Thu, 1 Feb 2024 19:28:48 -0500 Subject: [PATCH 2/7] removing changes in bundle-sdk to include access grants plugin dependency --- bundle-sdk/pom.xml | 2 -- 1 file changed, 2 deletions(-) diff --git a/bundle-sdk/pom.xml b/bundle-sdk/pom.xml index 7eec4ec89441..6d3cb33f46b5 100644 --- a/bundle-sdk/pom.xml +++ b/bundle-sdk/pom.xml @@ -76,8 +76,6 @@ commons-codec:commons-codec software.amazon.awssdk:* software.amazon:* - software.amazon.s3.accessgrants:* - com.github.benmanes.caffeine:* commons-logging:* From c78976eb3c706e3b129c991bf16bd883449b3eaa Mon Sep 17 00:00:00 2001 From: Shiva Kumar Mukkapati Date: Fri, 2 Feb 2024 13:19:50 -0500 Subject: [PATCH 3/7] adding access grants plugin to the include set of bundle-sdk --- bundle-sdk/pom.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/bundle-sdk/pom.xml b/bundle-sdk/pom.xml index 6d3cb33f46b5..2c29703dd583 100644 --- a/bundle-sdk/pom.xml +++ b/bundle-sdk/pom.xml @@ -76,6 +76,7 @@ commons-codec:commons-codec software.amazon.awssdk:* software.amazon:* + software.amazon.s3.accessgrants:* commons-logging:* From 18cce4c584e695c2aa869acb1a8e7d7a6ba302a4 Mon Sep 17 00:00:00 2001 From: Shiva Kumar Mukkapati Date: Fri, 2 Feb 2024 17:28:50 -0500 Subject: [PATCH 4/7] refactoring the access grants plugin inclusion + adding caffeine to the shaded jar --- aws-sdk-java/pom.xml | 6 ------ bundle-sdk/pom.xml | 16 ++++++++++++++++ pom.xml | 3 +++ 3 files changed, 19 insertions(+), 6 deletions(-) diff --git a/aws-sdk-java/pom.xml b/aws-sdk-java/pom.xml index 092e292d3ffe..ea562dec7d7a 100644 --- a/aws-sdk-java/pom.xml +++ b/aws-sdk-java/pom.xml @@ -728,11 +728,6 @@ Amazon AutoScaling, etc). s3control ${awsjavasdk.version} - - software.amazon.s3.accessgrants - aws-s3-accessgrants-java-plugin - ${s3accessgrants.version} - software.amazon.awssdk s3-transfer-manager @@ -1928,7 +1923,6 @@ Amazon AutoScaling, etc). software.amazon.awssdk:* - software.amazon.s3.accessgrants:* diff --git a/bundle-sdk/pom.xml b/bundle-sdk/pom.xml index 2c29703dd583..7120ddd184b0 100644 --- a/bundle-sdk/pom.xml +++ b/bundle-sdk/pom.xml @@ -56,6 +56,11 @@ ${awsjavasdk.version} true + + software.amazon.s3.accessgrants + aws-s3-accessgrants-java-plugin + ${s3accessgrants.version} + @@ -77,6 +82,7 @@ software.amazon.awssdk:* software.amazon:* software.amazon.s3.accessgrants:* + com.github.ben-manes.caffeine:* commons-logging:* @@ -114,6 +120,12 @@ + + + maven-dependency-plugin + org.apache.maven.plugins + + @@ -144,6 +156,10 @@ false + + maven-dependency-plugin + org.apache.maven.plugins + diff --git a/pom.xml b/pom.xml index e496beaafa23..37813ec8a1a8 100644 --- a/pom.xml +++ b/pom.xml @@ -537,6 +537,9 @@ old interfaces, but that should become a test scoped dependency in modules where needed. And the line below removed. --> software.amazon.awssdk:auth + + + software.amazon.s3.accessgrants:* From d2134b0968356a30246c01db0f01612dbe855bcf Mon Sep 17 00:00:00 2001 From: Shiva Kumar Mukkapati Date: Fri, 2 Feb 2024 17:50:46 -0500 Subject: [PATCH 5/7] removing unwanted dependency plugin added in bundle-sdk --- bundle-sdk/pom.xml | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/bundle-sdk/pom.xml b/bundle-sdk/pom.xml index 7120ddd184b0..33764aa6c72d 100644 --- a/bundle-sdk/pom.xml +++ b/bundle-sdk/pom.xml @@ -120,12 +120,7 @@ - - - maven-dependency-plugin - org.apache.maven.plugins - - + @@ -156,10 +151,6 @@ false - - maven-dependency-plugin - org.apache.maven.plugins - From a5591ec7c522a21e187e323557e3587bce1bc237 Mon Sep 17 00:00:00 2001 From: Shiva Kumar Mukkapati Date: Mon, 5 Feb 2024 15:08:45 -0500 Subject: [PATCH 6/7] bumping up S3 access grants plugin version --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 37813ec8a1a8..00b0b5585db4 100644 --- a/pom.xml +++ b/pom.xml @@ -178,7 +178,7 @@ 1.0.4 - 2.0.0 + 2.0.1 ${skipTests} ${project.basedir}/src/it/java @@ -538,7 +538,7 @@ And the line below removed. --> software.amazon.awssdk:auth - + software.amazon.s3.accessgrants:* From 5119619713a917c6cc86acfb343ccdf86978bad4 Mon Sep 17 00:00:00 2001 From: Shiva Kumar Mukkapati Date: Mon, 5 Feb 2024 15:20:40 -0500 Subject: [PATCH 7/7] fixing indentation --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 00b0b5585db4..bcd31139636b 100644 --- a/pom.xml +++ b/pom.xml @@ -538,7 +538,7 @@ And the line below removed. --> software.amazon.awssdk:auth - + software.amazon.s3.accessgrants:*