aws/request: IsErrorRetryable returns true for nil error #2773
Labels
bug
This issue is a bug.
Comments
1 task
jasdel
added a commit
to jasdel/aws-sdk-go
that referenced
this issue
Aug 21, 2019
Fixes aws#2773 where the IsErrorRetryable helper was incorrectly returning true for nil errors passed in. IsErrorRetryable will now correctly return false when the passed in error is nil like documented.
jasdel
added a commit
that referenced
this issue
Aug 22, 2019
Fixes #2773 where the IsErrorRetryable helper was incorrectly returning true for nil errors passed in. IsErrorRetryable will now correctly return false when the passed in error is nil like documented.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Please fill out the sections below to help us address your issue.
Version of AWS SDK for Go?
v1.23.0
Version of Go (
go version)?v1.12
What issue did you see?
#2744 (comment)
When we wrap the aws clients
Publish(*sns.PublishInput) (*sns.PublishOutput, error)with some of our own backoff/jitter we are using the error returned and passing that intorequest.IsErrorRetryable(error)which is causing us to always get true back for what we consider successful cases of nil error due to the addition of thecase nil: return truein this pr inside ofshouldRetryError.Steps to reproduce
Pass
niltoIsErrorRetryable.The text was updated successfully, but these errors were encountered: