Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry metric middleware probably shouldn't return error if no retry metadata #953

Closed
jasdel opened this issue Dec 7, 2020 · 2 comments
Closed

Comments

@jasdel
Copy link
Contributor

jasdel commented Dec 7, 2020

The retry metric middleware will return an error if it cannot find the retry metadata in the middleware context. This middleware should most likely just forward on the request instead of errorring out.

retryMetadata, ok := getRetryMetadata(ctx)
if !ok {
return out, metadata, fmt.Errorf("retry metadata value not found on context")
}

aws/smithy-go#163

@jasdel jasdel transferred this issue from aws/aws-sdk-go Dec 7, 2020
@jasdel jasdel added this to the v1.0 General Availability milestone Jan 8, 2021
@jasdel
Copy link
Contributor Author

jasdel commented Jan 14, 2021

Closed in #1031

@jasdel jasdel closed this as completed Jan 14, 2021
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant