Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompleteMultipartUpload xml has a bad tag name "CompletedMultipartUpload" (need remove the 'd' letter) #927

Closed
3 tasks done
nabbar opened this issue Nov 24, 2020 · 4 comments
Labels
bug This issue is a bug.

Comments

@nabbar
Copy link

nabbar commented Nov 24, 2020

Confirm by changing [ ] to [x] below to ensure that it's a bug:

Describe the bug
The xml sent to complete a multipart upload has a bad tag name. The tag name sent is "CompletedMultipartUpload" (cf line 153 in the file : https://github.com/aws/aws-sdk-go-v2/blob/master/service/s3/serializers.go#L153)
image

The AWS API reference documentation report that the tag name must be "CompleteMultipartUpload" (not the 'd' at the end of Complete word). You can find it at this link https://docs.aws.amazon.com/AmazonS3/latest/API/API_CompleteMultipartUpload.html :
image

I think this bug was appear with the v0.26.0 release and later (as the v0.29.0 I use).

Version of AWS SDK for Go: v0.29.0

Version of Go : go1.15.2

@nabbar nabbar added the bug This issue is a bug. label Nov 24, 2020
@nabbar
Copy link
Author

nabbar commented Nov 25, 2020

Strangely, when I looking for this bug into the smithy definition model json, I don't find it

https://github.com/aws/aws-sdk-go-v2/blob/v0.29.0/codegen/sdk-codegen/aws-models/s3.2006-03-01.json#L1185
image

Maybe a bug into the codegen ?

Or need defined the xmlname into the traits definition of the structure CompletedMultipartUpload at line 1208 ?https://github.com/aws/aws-sdk-go-v2/blob/v0.29.0/codegen/sdk-codegen/aws-models/s3.2006-03-01.json#L1208

image

thanks in advance for helping :)

@skmcgrail skmcgrail added needs-triage This issue or PR still needs to be triaged. and removed needs-triage This issue or PR still needs to be triaged. labels Dec 2, 2020
@skmcgrail
Copy link
Member

Thank you for bringing this to our attention @nabbar and your detailed research into the issue. This appears to be an edge case in our code generation that is not correctly applying the xmlName trait. We will work on getting this fixed in our next release.

@skmcgrail skmcgrail added this to the v1.0 Release Candidate milestone Dec 2, 2020
@jasdel
Copy link
Contributor

jasdel commented Dec 17, 2020

This issue was fixed in #965 and will be included in the SDK's tagged release.

@jasdel jasdel closed this as completed Dec 17, 2020
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants