Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support endpoint configuration via env and shared config #2226

Closed
2 tasks
adrianlungu opened this issue Aug 8, 2023 · 6 comments · Fixed by #2328
Closed
2 tasks

Support endpoint configuration via env and shared config #2226

adrianlungu opened this issue Aug 8, 2023 · 6 comments · Fixed by #2328
Assignees
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue pending-release This issue will be fixed by an approved PR that hasn't been released yet.

Comments

@adrianlungu
Copy link

Describe the feature

Given that the AWS-CLI has received support for endpoint configuration via AWS_ENDPOINT_URL env vars, or the shared config file, as detailed here: https://aws.amazon.com/blogs/developer/new-improved-flexibility-when-configuring-endpoint-urls-with-the-aws-sdks-and-tools/

It would be nice if the Go AWS SDK also supported this to be able to configure the AWS endpoint url automatically as done with other variables, without having to explicitly specify it in code.

Use Case

Configuring the AWS session via environment variables or the shared configuration file without having to maintain the variable in multiple places to pass it to code via a WithEndpoint func.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

AWS Go SDK V2 Module Versions Used

github.com/aws/aws-sdk-go-v2 v1.20.1

Go version used

go1.20.5, MacOS Ventura 13.5

@adrianlungu adrianlungu added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 8, 2023
@lucix-aws
Copy link
Contributor

Thanks for the feature request.

This is actually a cross-SDK initiative (and it appears it has already landed in the CLI) that we were tracking internally. We'll leave this feature request open for visibility.

@lucix-aws lucix-aws added queued This issues is on the AWS team's backlog and removed needs-triage This issue or PR still needs to be triaged. labels Aug 8, 2023
@lucix-aws lucix-aws changed the title Support for AWS_ENDPOINT_URL Support endpoint configuration via env and shared config Aug 8, 2023
@bhechinger
Copy link

I was just searching this exact thing yesterday myself as well. Is there any idea of an ETA for when this might be released?

@lucix-aws lucix-aws added p1 This is a high priority issue and removed queued This issues is on the AWS team's backlog labels Sep 19, 2023
@lucix-aws lucix-aws added p2 This is a standard priority issue and removed p1 This is a high priority issue labels Oct 11, 2023
@lucix-aws lucix-aws linked a pull request Oct 20, 2023 that will close this issue
@lucix-aws
Copy link
Contributor

lucix-aws commented Oct 20, 2023

Will be resolved by #2328.

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@lucix-aws lucix-aws reopened this Oct 30, 2023
@lucix-aws
Copy link
Contributor

lucix-aws commented Oct 30, 2023

This is being held back from release temporarily to investigate/resolve a moduling issue which is preventing us from being able to perform the minimum go version bump to 1.19.

Resolved and re-merged.

@lucix-aws lucix-aws added the pending-release This issue will be fixed by an approved PR that hasn't been released yet. label Oct 30, 2023
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue pending-release This issue will be fixed by an approved PR that hasn't been released yet.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants