Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove exclusionary logic from schema generation #5641

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

Leo10Gama
Copy link
Member

Why is this change necessary?

While the schema was being created, it was generated in pieces to make reviewing it easier, and less prone to errors in generation. Now that the schema is fully generated and approved of, we no longer need this additional logic.

How does it address the issue?

Any logic the schema previously implemented to exclude certain commands from appearing has been removed.

What side effects does this change have?

N/A

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Leo10Gama Leo10Gama requested a review from a team as a code owner July 28, 2023 20:07
@Leo10Gama Leo10Gama requested review from lucashuy and moelasmar July 28, 2023 20:07
@github-actions github-actions bot added pr/external area/schema JSON schema file stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Jul 28, 2023
@hnnasit hnnasit merged commit 354e4ae into aws:feat/json-schema Jul 28, 2023
@Leo10Gama Leo10Gama deleted the remove-exclusions branch July 28, 2023 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/schema JSON schema file pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants