From f4ee64203d8d5c5c7c70fdc35089e551469bf6bf Mon Sep 17 00:00:00 2001 From: Chris/0 Date: Thu, 26 Aug 2021 21:02:05 -0400 Subject: [PATCH] Address Pull Request Feedback - Suppress First-Time Run Messages - Redirect Nuget Warmup Output - Justify Nuget Warmup Procedure --- build-image-src/Dockerfile-dotnetcore31 | 6 +++++- tests/test_build_images.py | 3 +-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/build-image-src/Dockerfile-dotnetcore31 b/build-image-src/Dockerfile-dotnetcore31 index db39a51..3ce87ee 100644 --- a/build-image-src/Dockerfile-dotnetcore31 +++ b/build-image-src/Dockerfile-dotnetcore31 @@ -55,15 +55,19 @@ ENV DOTNET_ROOT=/var/lang/bin # Install .NET build tools +# Suppress first-time output. +ENV DOTNET_NOLOGO=true + ENV PATH=/root/.dotnet/tools:$PATH \ AWS_EXECUTION_ENV=AWS_Lambda_dotnetcore3.1 \ DOTNET_CLI_TELEMETRY_OPTOUT=1 \ NUGET_XMLDOC_MODE=skip +# Warm up the nuget cache once now for faster startup on each use. RUN curl -L https://dot.net/v1/dotnet-install.sh | bash -s -- -c 3.1 -i "${DOTNET_ROOT}" && \ mkdir /tmp/warmup && \ cd /tmp/warmup && \ - dotnet new && \ + dotnet new > /dev/null && \ cd / && \ rm -rf /tmp/warmup /tmp/NuGetScratch /tmp/.dotnet diff --git a/tests/test_build_images.py b/tests/test_build_images.py index 08970cf..b8b68fc 100644 --- a/tests/test_build_images.py +++ b/tests/test_build_images.py @@ -161,6 +161,7 @@ def test_packages(self): self.assertTrue(self.check_package_output("python --version", "Python 3.8.")) self.assertTrue(self.is_package_present("pip")) + # class TestBIPython39(BuildImageBase): # __test__ = True @@ -176,8 +177,6 @@ def test_packages(self): # self.assertTrue(self.is_package_present("pip")) - - class TestBIDotNetCore31(BuildImageBase): __test__ = True