fix: ensure aspects run for Pipeline stages #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportWe didn't find any information for the current pull request with the commit db2791d. Check the Nx Cloud Github Integration documentation for more information. Sent with 💌 from NxCloud. |
diranged
added a commit
to Nextdoor/cdk-pipelines-github
that referenced
this pull request
Mar 24, 2024
The AWS CDK docs clearly state that `Aspects` do not cross `Stage` boundaries ... which is an unexpected behavior. Its so unexpected that Amazon's own `aws-pdk` project [implemented this patch](aws/aws-pdk#94) to work around the issue. Most of our projects use the `GItHubWorkflow` pipeline - so fixing it here is a natural way to implement the behavior we _expect_ to see. Ref: aws/aws-cdk#20468, https://github.com/aws/aws-pdk/pull/94/files Co-authored-by: Matt Wise <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the below CDK issues by propagating all Aspects applied at the root level (App) to stages when they are added to the pipeline.
aws/aws-cdk#20468
aws/aws-cdk#17805