Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update kind to v0.6.0 and move ec2-meta-data-proxy to test root #32

Merged
merged 1 commit into from
Dec 4, 2019

Conversation

bwagner5
Copy link
Contributor

@bwagner5 bwagner5 commented Dec 2, 2019

Issue #, if available:
N/A

Description of changes:

  • Updated KinD to v0.6.0
  • Moved the test metadata into test root so that it can be used across future tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@bwagner5 bwagner5 marked this pull request as ready for review December 2, 2019 22:57
@@ -0,0 +1,3 @@
module github.com/aws/aws-node-termination-handler/ec2-meta-data-proxy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's steer clear of Go submodules in the repo. multi-module repos are an extreme pain in the you-know-what. I've learned this from painful experience recently:

https://github.com/golang/go/wiki/Modules#should-i-have-multiple-modules-in-a-single-repository
golang/go#35878

In short, if we used multiple Go modules in a single repo, we'd need to remember to apply a semver "prefixed" Git tag every time we issued a release, one for each Go submodule. It's a recipe for disaster and we can do just fine with a single semver Git-tagged repo with a single root Go.mod.

Copy link
Contributor

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know, the more I think about it, the more I think this PR is a perfect opportunity to rename the binary here to make it 100% clear it's simply a test helper/fake and not something that should or would be deployed to a production setup.

How about we rename cmd/ec2-meta-data-proxy to cmd/test-ec2-metadata-fake or cmd/ec2-metadata-test-proxy or cmd/ec2-metadata-test-helper (your choice)?

Thoughts?
-jay

@bwagner5
Copy link
Contributor Author

bwagner5 commented Dec 3, 2019

yeah that's not a bad idea, I think I like ec2-metadata-test-proxy, I'll update

Copy link
Contributor

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making that name change, Brandon!

@jaypipes jaypipes merged commit 3ef3044 into aws:master Dec 4, 2019
@bwagner5 bwagner5 deleted the test-updates branch July 15, 2020 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants