refactor: simply connection string builder class so it is easier to update the class #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColinKYuen
approved these changes
Jan 21, 2025
karenc-bq
force-pushed
the
refactor/connection_string_builder
branch
4 times, most recently
from
1f6ad2d to
a0396b6
Compare
karenc-bq
force-pushed
the
refactor/connection_string_builder
branch
from
a0396b6 to
ce4ab90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current implementation is bloated with repetitive and verbose code. Adding a new connection variable requires adding 2 new methods, 2 new variables, and 1 new if condition.
After this change we only need to add 1 method for new variables.
This change also updates the constructor so requires parameters must be passed in through the constructor, thus reducing number of checks required.
Description
Review Status
Additional Reviewers