clearing SubscriptionList entries in shadowActionAcks after subscription failure

[PTaylor-RA]

I'm using multiple threads which is probably why I noticed this.

if(clearBothEntriesFromList) {
    if(indexAcceptedSubList >= 0) {
        SubscriptionList[indexAcceptedSubList].isFree = true;
    } else if(indexRejectedSubList >= 0) {
        SubscriptionList[indexRejectedSubList].isFree = true;
    }
    if(SubscriptionList[indexAcceptedSubList].count == 1) {
        aws_iot_mqtt_unsubscribe(pMqttClient, SubscriptionList[indexAcceptedSubList].Topic,
	    (uint16_t)strlen(SubscriptionList[indexAcceptedSubList].Topic));
    }
}

should be:

if(clearBothEntriesFromList) {
    if(indexAcceptedSubList >= 0) {
        SubscriptionList[indexAcceptedSubList].isFree = true;
    }
    if(indexRejectedSubList >= 0) {
        SubscriptionList[indexRejectedSubList].isFree = true;
    }
    if(SubscriptionList[indexAcceptedSubList].count == 1) {
        aws_iot_mqtt_unsubscribe(pMqttClient, SubscriptionList[indexAcceptedSubList].Topic,
									 (uint16_t) strlen(SubscriptionList[indexAcceptedSubList].Topic));
    }
}

[chaurah]

Hi @PTaylor-RA,
Thank you for pointing this out. I have added this to the list of bug fixes to be included with the next SDK release. I will update and close this issue when the release is out.

Please do let us know if you have any further suggestions.

Rahul