Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SECURITY ISSUE: Buffer overflow in parseStringValue #151

Closed
kennu opened this issue Apr 4, 2018 · 2 comments
Closed

SECURITY ISSUE: Buffer overflow in parseStringValue #151

kennu opened this issue Apr 4, 2018 · 2 comments

Comments

@kennu
Copy link

kennu commented Apr 4, 2018

There is a buffer overflow in the function

IoT_Error_t parseStringValue(char *buf, const char *jsonString, jsmntok_t *token) {

It copies data to destination buf without checking buf size. This will potentially cause serious security problems on IoT devices when arbitrary JSON data is processed.

@aggarg
Copy link
Member

aggarg commented Apr 5, 2018

Hello @kennu,

Thank you for reporting your observation. We are looking into it.

Regards,
Gaurav

@lt72
Copy link
Contributor

lt72 commented Apr 23, 2018

This has now been resolved with changes #152 and #155. Please use release v3.0.0 (https://github.com/aws/aws-iot-device-sdk-embedded-C/tree/v3.0.0) to acquire the changes and refer to appropriate section in the README for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants