Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to pass extra parameters to aws ec2-instance-connect ssh #8952

Open
2 tasks
lcswillems opened this issue Sep 28, 2024 · 4 comments
Open
2 tasks

Allow to pass extra parameters to aws ec2-instance-connect ssh #8952

lcswillems opened this issue Sep 28, 2024 · 4 comments
Labels
customization Issues related to CLI customizations (located in /awscli/customizations) ec2-instance-connect feature-request A feature should be added or improved. p3 This is a minor priority issue

Comments

@lcswillems
Copy link

Describe the feature

Allow to pass extra parameters to aws ec2-instance-connect ssh

Use Case

E.g. I want to start the tunnel in the background.

If I was using the SSH directly, I would do:

ssh -o "StrictHostKeyChecking=accept-new" -f -N -L $DOCKER_TCP_HOSTNAME:/var/run/docker.sock -i $KEY $INSTANCE_USER@$INSTANCE_IP

With aws ec2-instance-connect ssh, it would be great to do:

aws ec2-instance-connect ssh -- -o "StrictHostKeyChecking=accept-new" -f -N -L $DOCKER_TCP_HOSTNAME:/var/run/docker.sock

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CLI version used

aws-cli/2.17.61 Python/3.12.6 Linux/6.8.0-40-generic exe/x86_64.ubuntu.22

Environment details (OS name and version, etc.)

Ubuntu

@lcswillems lcswillems added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 28, 2024
@adev-code adev-code self-assigned this Sep 30, 2024
@adev-code adev-code added investigating This issue is being investigated and/or work is in progress to resolve the issue. ec2 p3 This is a minor priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Sep 30, 2024
@adev-code
Copy link

Hello @lcswillems, thanks for reaching out! This customization is maintained by an EC2 team, so I'll reach out to them for feedback on this feature request. Also, please mention your use case for the team's understanding. Please let me know if you have any other questions. Thanks!

Ticket # for internal reference : P159335852

@adev-code adev-code added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Oct 3, 2024
@tim-finnigan tim-finnigan added customization Issues related to CLI customizations (located in /awscli/customizations) ec2-instance-connect and removed ec2 labels Oct 3, 2024
@lcswillems
Copy link
Author

The use case is specified in the issue. Please let me know which details are missing. I gave a concrete example of what I would like to do.

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Oct 3, 2024
@adev-code adev-code added needs-review This issue or pull request needs review from a core team member. and removed needs-review This issue or pull request needs review from a core team member. labels Oct 8, 2024
@lcswillems
Copy link
Author

Hey @adev-code, do you know what's the status on this one?

@adev-code
Copy link

Hello @lcswillems, thanks for getting back. The EC2 team maintaining this customization discussed your feature request, and acknowledged that it would be a beneficial enhancement of the plugin. They have added this feature request to their backlog for tracking. We cannot guarantee if or when the feature would be implemented, but please refer to the AWS CLI changelog for updates going forward (https://raw.githubusercontent.com/aws/aws-cli/v2/CHANGELOG.rst) for updates about this going forward. Meanwhile, you can use your own ssh client as outlined on our public documentation: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ec2-instance-connect-methods.html#ec2-instance-connect-connecting-aws-cli. Please let me know if you have any other questions. Thanks!

@adev-code adev-code removed their assignment Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customization Issues related to CLI customizations (located in /awscli/customizations) ec2-instance-connect feature-request A feature should be added or improved. p3 This is a minor priority issue
Projects
None yet
Development

No branches or pull requests

3 participants