Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(custom-resources): update python runtime for custom resources #31166

Merged
merged 22 commits into from
Sep 4, 2024
Merged

chore(custom-resources): update python runtime for custom resources #31166

merged 22 commits into from
Sep 4, 2024

Conversation

GavinZZ
Copy link
Contributor

@GavinZZ GavinZZ commented Aug 20, 2024 •
edited
Loading

Issue # (if applicable)

Closes #31245

Reason for this change

Support latest python runtime that's available everywhere

Description of changes

Update custom resource handler runtime to python 3.11

Description of how you validated changes

There were initially 40+ failed integration tests due to this change, all these tests are re-ran by deploying and verifying (no dry-run flag used). Now all existing tests are passing.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Aug 20, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team August 20, 2024 21:33
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 20, 2024
@GavinZZ GavinZZ force-pushed the python_custom_resource_update branch 2 times, most recently from 5bdc378 to 1ce3320 Compare August 23, 2024 22:47
@GavinZZ GavinZZ marked this pull request as ready for review August 28, 2024 18:13
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 28, 2024
@moelasmar moelasmar added the pr/do-not-merge This PR should not be merged at this time. label Aug 28, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 28, 2024
@moelasmar moelasmar removed the pr/do-not-merge This PR should not be merged at this time. label Aug 28, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 28, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions github-actions bot added bug This issue is a bug. p1 and removed p2 labels Aug 28, 2024
@GavinZZ GavinZZ force-pushed the python_custom_resource_update branch from ddabfd5 to 2e81e5b Compare August 29, 2024 17:41
@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 29, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@moelasmar moelasmar added the pr/do-not-merge This PR should not be merged at this time. label Aug 29, 2024
@moelasmar moelasmar self-requested a review August 29, 2024 19:04
@github-actions github-actions bot mentioned this pull request Sep 1, 2024
Closed
@GavinZZ GavinZZ force-pushed the python_custom_resource_update branch from f396b8a to 0bbdcd8 Compare September 4, 2024 17:31
@GavinZZ
Copy link
Contributor Author

GavinZZ commented Sep 4, 2024

@mergify update

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 4, 2024

update

✅ Branch has been successfully updated

@GavinZZ GavinZZ force-pushed the python_custom_resource_update branch from d5e1eaa to 78b20c1 Compare September 4, 2024 20:18
@GavinZZ
Copy link
Contributor Author

GavinZZ commented Sep 4, 2024

@mergify update

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 4, 2024

update

✅ Branch has been successfully updated

@GavinZZ
Copy link
Contributor Author

GavinZZ commented Sep 4, 2024

@mergify update

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 4, 2024

update

✅ Branch has been successfully updated

@paulhcsun
Copy link
Contributor

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 4, 2024

update

✅ Branch has been successfully updated

@GavinZZ
Copy link
Contributor Author

GavinZZ commented Sep 4, 2024

@mergify refresh

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 4, 2024

refresh

✅ Pull request refreshed

@GavinZZ GavinZZ removed the pr/do-not-merge This PR should not be merged at this time. label Sep 4, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 4, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 6c4f0a5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 03ebca8 into main Sep 4, 2024
11 of 12 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 4, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot deleted the python_custom_resource_update branch September 4, 2024 23:57
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@moelasmar moelasmar moelasmar approved these changes

Assignees
No one assigned
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(custom-resources): (custom resource python 3.11 runtime deployment fails for certain new regions)
4 participants
@GavinZZ @paulhcsun @aws-cdk-automation @moelasmar