-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ecs): add fargate ephemeral storage encryption to cluster settings #30759
feat(ecs): add fargate ephemeral storage encryption to cluster settings #30759
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
09a2fa0
to
440799d
Compare
36c3324
to
f0e72cd
Compare
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍 Left some comments for adjustments
...aws-cdk-testing/framework-integ/test/aws-ecs/test/integ.cluster-encrypt-ephemeral-storage.ts
Outdated
Show resolved
Hide resolved
2a1f506
to
4030fb1
Compare
TBH this integration test stuff is so frustrating.. it works on my machine + account. I have no idea why it always fails in the pipeline.... the logs are not very helpful either |
@jaecktec Other snapshots have changed (I guess due to your changes). Just make sure to update those and I think you're good to go. Below I added a snippet of some changes, there are more in the logs.
|
2419cdd
to
43456d9
Compare
fc2ed05
to
a3d6207
Compare
also return undefined if neither storage nor executeCommand config are set
412c29e
to
f0389ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for contributing!
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #30721
Reason for this change
Expose api on ECS L2 Cluster construct to encrypt fargate ephemeral storage
Description of changes
adds new property to pass key for encrypton.
Updates key policy according to developer documentation
Description of how you validated changes
Added unit tests to validate cases where cluster has a generated name or a specified name.
When name is random, the key policy can't be as restrictive since it will generate a cyclic dependency issue due to the Key Policy being inline in KMS
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license