Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ses): add scalingMode property to dedicated ip pool #28392

Merged
merged 12 commits into from
Dec 19, 2023
Merged

feat(ses): add scalingMode property to dedicated ip pool #28392

merged 12 commits into from
Dec 19, 2023

Conversation

badmintoncryer
Copy link
Contributor

Closes #27418

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Dec 16, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team December 16, 2023 03:35
aws-cdk-automation
aws-cdk-automation previously requested changes Dec 16, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation dismissed their stale review December 16, 2023 03:41

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@badmintoncryer badmintoncryer changed the title feat(ses): add scailingMode property to dedicated ip pool feat(ses): add scalingMode property to dedicated ip pool Dec 16, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 16, 2023
lpizzinidev
lpizzinidev suggested changes Dec 16, 2023
View reviewed changes
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution 👍
I left some notes for minor adjustments.

packages/@aws-cdk-testing/framework-integ/test/aws-ses/test/integ.dedicated-ip-pool.ts Outdated
Comment on lines 8 to 13
// new ses.DedicatedIpPool(stack, 'Pool', {
// dedicatedIpPoolName: 'myPool',
// scalingMode: ses.ScalingMode.MANAGED,
// });

new ses.DedicatedIpPool(stack, 'Pool', {});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// new ses.DedicatedIpPool(stack, 'Pool', {
// dedicatedIpPoolName: 'myPool',
// scalingMode: ses.ScalingMode.MANAGED,
// });
new ses.DedicatedIpPool(stack, 'Pool', {});
new ses.DedicatedIpPool(stack, 'Pool', {
dedicatedIpPoolName: 'myPool',
scalingMode: ses.ScalingMode.MANAGED,
});

Incomplete integration test.

Copy link
Contributor Author

@badmintoncryer badmintoncryer Dec 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your review!

I conducted the integration test again after making the modifications.

Atfirst, I tried conducting an integration test, but failed to create an IP pool. It seems that the 'poolName' must be within 64 characters and only allow lowercase letters, numbers, periods, dashes and underscores. (Deployment fails because 'myPool' includes uppercase letters.)

I have added the above conditions to the description of 'dedicatedIpPoolName', but is it okay to include such a modification in this Pull Request?

packages/aws-cdk-lib/aws-ses/lib/dedicated-ip-pool.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-ses/lib/dedicated-ip-pool.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-ses/lib/dedicated-ip-pool.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-ses/lib/dedicated-ip-pool.ts Outdated Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 16, 2023
@badmintoncryer
Copy link
Contributor Author

@lpizzinidev
Thank you for the review. And I apologize for the easy mistakes...

lpizzinidev
lpizzinidev approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 18, 2023
kaizencc
kaizencc previously approved these changes Dec 19, 2023
View reviewed changes
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 19, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 19, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 19, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed kaizencc’s stale review December 19, 2023 16:55

Pull request has been modified.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 19, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: d1e1606
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit c687778 into aws:main Dec 19, 2023
10 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 19, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@badmintoncryer badmintoncryer deleted the 27418-scailingMode branch December 20, 2023 01:13
@github-actions github-actions bot mentioned this pull request Jan 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumupitchayan sumupitchayan sumupitchayan approved these changes

@lpizzinidev lpizzinidev lpizzinidev approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

@kaizencc kaizencc kaizencc left review comments

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(aws-ses): expose scalingMode property on DedicatedIPPool
5 participants
@badmintoncryer @aws-cdk-automation @lpizzinidev @sumupitchayan @kaizencc