-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): incorrect CloudFormation date formatting #28149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
I left you a note on an added file.
Also, the dateToCloudFormation
method is used when parsing dates for ScheduledAction
's StartTime
and EndTime
.
Can you please add integration/unit tests for that as well?
(You can use this as a starting point).
Finally, I'm not sure about the title, it should describe the bug (not the solution).
Something like fix(core): wrong CloudFormation date formatting
is probably more aligned.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
@lpizzinidev I updated the PR with the other integration test. 👍🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me. Thank you for your contribution.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
The trailing
Z
is now required:Closes #28065, #28124.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license