Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): incorrect CloudFormation date formatting #28149

Merged
merged 5 commits into from
Nov 28, 2023
Merged

Conversation

msambol
Copy link
Contributor

@msambol msambol commented Nov 27, 2023

The trailing Z is now required:

Closes #28065, #28124.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team November 27, 2023 14:06
@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p2 admired-contributor [Pilot] contributed between 13-24 PRs to the CDK labels Nov 27, 2023
@msambol msambol changed the title fix(s3): lifecycle rule dates require trailing Z fix(core): s3 lifecycle rule dates require trailing Z Nov 27, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 27, 2023
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
I left you a note on an added file.

Also, the dateToCloudFormation method is used when parsing dates for ScheduledAction's StartTime and EndTime.
Can you please add integration/unit tests for that as well?
(You can use this as a starting point).

Finally, I'm not sure about the title, it should describe the bug (not the solution).
Something like fix(core): wrong CloudFormation date formatting is probably more aligned.

packages/@aws-cdk/cli-lib-alpha/THIRD_PARTY_LICENSES Outdated Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 28, 2023
@msambol msambol changed the title fix(core): s3 lifecycle rule dates require trailing Z fix(core): incorrect CloudFormation date formatting Nov 28, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3ff4bb8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@msambol
Copy link
Contributor Author

msambol commented Nov 28, 2023

@lpizzinidev I updated the PR with the other integration test. 👍🏼

Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 28, 2023
Copy link
Contributor

@SankyRed SankyRed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me. Thank you for your contribution.

Copy link
Contributor

mergify bot commented Nov 28, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 1624ab6 into aws:main Nov 28, 2023
14 checks passed
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admired-contributor [Pilot] contributed between 13-24 PRs to the CDK bug This issue is a bug. effort/medium Medium work item – several days of effort p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

s3 LifecycleRule.ExpirationDate: due to changes in CFN validation last week - template format is broken
5 participants