From 2fd93dba7861dfe25700b4ad307ff6cf5474fffc Mon Sep 17 00:00:00 2001 From: Rico Huijbers Date: Tue, 19 Mar 2019 12:41:36 +0100 Subject: [PATCH] chore: update `desiredCapacity` in README Update `instanceCount` => `desiredCapacity` in ECS README. Fixes #1926. --- packages/@aws-cdk/aws-ecs/README.md | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/packages/@aws-cdk/aws-ecs/README.md b/packages/@aws-cdk/aws-ecs/README.md index 81ada6f31abb1..6539c47812830 100644 --- a/packages/@aws-cdk/aws-ecs/README.md +++ b/packages/@aws-cdk/aws-ecs/README.md @@ -23,7 +23,7 @@ const cluster = new ecs.Cluster(this, 'Cluster', { // Add capacity to it cluster.addDefaultAutoScalingGroupCapacity('Capacity', { instanceType: new ec2.InstanceType("t2.xlarge"), - instanceCount: 3, + desiredCapacity: 3, }); // Instantiate Amazon ECS Service with an automatic load balancer @@ -91,7 +91,7 @@ const cluster = new ecs.Cluster(this, 'Cluster', { // Either add default capacity cluster.addDefaultAutoScalingGroupCapacity({ instanceType: new ec2.InstanceType("t2.xlarge"), - instanceCount: 3, + desiredCapacity: 3, }); // Or add customized capacity. Be sure to start the Amazon ECS-optimized AMI. @@ -266,7 +266,7 @@ const autoScalingGroup = cluster.addDefaultAutoScalingGroupCapacity({ instanceType: new ec2.InstanceType("t2.xlarge"), minCapacity: 3, maxCapacity: 30 - instanceCount: 3, + desiredCapacity: 3, // Give instances 5 minutes to drain running tasks when an instance is // terminated. This is the default, turn this off by specifying 0 or @@ -294,4 +294,3 @@ To start an Amazon ECS task on an Amazon EC2-backed Cluster, instantiate an ## Roadmap - [ ] Service Discovery Integration -- [ ] Private registry authentication