chore(kms): overridden validate method must be protected #9616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
MrArnoldPalmer
approved these changes
Aug 12, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
RomainMuller
added a commit
to aws/jsii
that referenced
this pull request
Aug 12, 2020
Since C# does not allow changing the visibility of a member when overriding it, added a check to ensure nobody attempts to make a protected member public when overriding it. This is a somewhat common pitfall for users (as seen for example in aws/aws-cdk#9616), and the check will allow faster detection and correction (i.e: at compilation time instead of during `jsii-pacmak`).
RomainMuller
added a commit
to aws/jsii
that referenced
this pull request
Aug 12, 2020
Since C# does not allow changing the visibility of a member when overriding it, added a check to ensure nobody attempts to make a protected member public when overriding it. This is a somewhat common pitfall for users (as seen for example in aws/aws-cdk#9616), and the check will allow faster detection and correction (i.e: at compilation time instead of during `jsii-pacmak`).
|
Sorry for causing this error (and thanks for catching it)! I think at some point in my PR I was using the method as public to work around a temporary issue, and thought it was okay since I saw another public |
|
No worries, we should have caught it in build time, and now we do: aws/jsii@cfc99c2 thanks @RomainMuller <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR #9269, implemented
validate()on the KMS key construct. Since this methods overrideConstructvalidateit must have the same visibility modifier -protected. Changing visibility modifier on override methods breaksjsii-pacmak, specifically C# packaging.:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license