Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@aws-cdk/assert] Assertions library for Python #9614

Closed
srethira opened this issue Aug 11, 2020 · 10 comments
Closed

[@aws-cdk/assert] Assertions library for Python #9614

srethira opened this issue Aug 11, 2020 · 10 comments
Labels
@aws-cdk/assert Related to the @aws-cdk/assert package effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. language/python Related to Python bindings p1 testing Related to tests needed to be modified or added.

Comments

@srethira
Copy link

srethira commented Aug 11, 2020

@aws-cdk/assert is only available in Typescript and Javascript. Would like this feature to be supported in Python for Unit and Integration testing.

@srethira srethira added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 11, 2020
@SomayaB SomayaB added language/python Related to Python bindings testing Related to tests needed to be modified or added. labels Aug 12, 2020
@SomayaB SomayaB changed the title Assertions library for Python [@aws-cdk/assert] Assertions library for Python Aug 12, 2020
@github-actions github-actions bot added the @aws-cdk/assert Related to the @aws-cdk/assert package label Aug 12, 2020
@nija-at nija-at added the p1 label Aug 17, 2020
@nija-at nija-at added the effort/large Large work item – several weeks of effort label Sep 22, 2020
@Juberstine
Copy link

+1

3 similar comments
@Zirkonium88
Copy link

+1

@wuqunfei
Copy link

wuqunfei commented Oct 4, 2020

+1

@elgamala
Copy link

elgamala commented Oct 9, 2020

+1

@SomayaB SomayaB removed the needs-triage This issue or PR still needs to be triaged. label Nov 6, 2020
@domtes
Copy link

domtes commented Nov 23, 2020

While trying to build my an assertion library in Python I've found out that the aws-cdk.cloudformation-diff packages is not exported to other languages.

Making it available would be useful to build a consistent assertion library in python and other languages.
The language-specific assertion libraries could then be built mimicking the same design of the embedded Typescript one.

@nideveloper
Copy link
Contributor

As more and more languages are supported by CDK, a consistent infra testing experience is 100% needed. I thought there already was an issue or an RFC for a multi lang assert library from 2018/19 but I can't find it now. It may be this on the rfc aws/aws-cdk-rfcs#4

@nija-at
Copy link
Contributor

nija-at commented Jan 11, 2021

Thanks @nideveloper and others. We've heard this feedback from customers and intend to make this available for all our supported languages.

The work involved is non-trivial, so it may be a bit of time before we can get to this.

@michaelbrewer
Copy link
Contributor

yep, otherwise Typescript is the only runtime that is fully supported

@nija-at
Copy link
Contributor

nija-at commented Aug 3, 2021

This work is complete. Please use the new module '@aws-cdk/assertions' that is available in all languages.

@nija-at nija-at closed this as completed Aug 3, 2021
@github-actions
Copy link

github-actions bot commented Aug 3, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/assert Related to the @aws-cdk/assert package effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. language/python Related to Python bindings p1 testing Related to tests needed to be modified or added.
Projects
None yet
Development

No branches or pull requests

10 participants