Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda): bundling docker image does not exist for Go runtime #9465

Merged
merged 3 commits into from
Aug 6, 2020

Conversation

nija-at
Copy link
Contributor

@nija-at nija-at commented Aug 5, 2020

The official docker images for lambda are not available yet for Go and
dotnet core runtimes. Switch back to using lambdaci in these cases.

fixes #9435


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

The official docker images for lambda are not available yet for Go and
dotnet core runtimes. Switch back to using lambdaci in these cases.

fixes #9435
@nija-at nija-at requested a review from a team August 5, 2020 17:51
@nija-at nija-at self-assigned this Aug 5, 2020
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 5, 2020
@nija-at nija-at added the pr-linter/exempt-test The PR linter will not require test changes label Aug 5, 2020
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing test

@nija-at
Copy link
Contributor Author

nija-at commented Aug 5, 2020

What sort of test are you looking for here?

@nija-at nija-at requested review from eladb and a team August 5, 2020 18:34
@eladb
Copy link
Contributor

eladb commented Aug 5, 2020

What sort of test are you looking for here?

That the expected images are used for the various runtimes.

@nija-at nija-at removed the pr-linter/exempt-test The PR linter will not require test changes label Aug 6, 2020
@mergify
Copy link
Contributor

mergify bot commented Aug 6, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Aug 6, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 7666d9b into master Aug 6, 2020
@mergify mergify bot deleted the nija-at/lambda-dockerimg branch August 6, 2020 13:53
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: b163d7b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

eladb pushed a commit that referenced this pull request Aug 10, 2020
The official docker images for lambda are not available yet for Go and
dotnet core runtimes. Switch back to using lambdaci in these cases.

fixes #9435


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[lambda] lambda.Runtime.GO_1_X.bundlingDockerImage doesn't exist
3 participants