fix(ecs-patterns): Adds missing option to secure ingress of ALB in Ap… #9434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plicationLoadBalancedEc2Service
iamhopaul123
approved these changes
Aug 5, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
piradeepk
approved these changes
Aug 5, 2020
There was a problem hiding this comment.
Ship it! 💯 Thanks for adding the ability to restrict ingress traffic @ddneilson!
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
eladb
pushed a commit
that referenced
this pull request
Aug 10, 2020
#9434) This adds the option: ``` /** * Determines whether or not the Security Group for the Load Balancer's Listener will be open to all traffic by default. * * @default true -- The security group allows ingress from all IP addresses. */ readonly openListener?: boolean; ``` to `ApplicationLoadBalancedServiceBase` so that it is possible to restrict ingress to the listener created by the pattern. Fixes: #9433 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the option:
to
ApplicationLoadBalancedServiceBaseso that it is possible to restrict ingress to the listener created by the pattern.Fixes: #9433
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license