Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dynamodb): allow using PhysicalName.GENERATE_IF_NEEDED as the Table name #9377

Merged
merged 2 commits into from
Aug 2, 2020
Merged

fix(dynamodb): allow using PhysicalName.GENERATE_IF_NEEDED as the Table name #9377

merged 2 commits into from
Aug 2, 2020

Conversation

skinny85
Copy link
Contributor

Fixes #9374

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@skinny85 skinny85 requested a review from RomainMuller July 31, 2020 22:30
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 31, 2020
NetaNir
NetaNir reviewed Aug 2, 2020
View reviewed changes
packages/@aws-cdk/aws-dynamodb/lib/table.ts
this.tableArn = this.getResourceArnAttribute(this.table.attrArn, {
service: 'dynamodb',
resource: 'table',
resourceName: this.physicalName,
});
this.tableName = this.getResourceNameAttribute(this.table.ref);

if (props.tableName) { this.node.addMetadata('aws:cdk:hasPhysicalName', this.tableName); }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my own understanding, what is this? This is the only place in the CDK this pattern is used

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was an old idea to mark things with physical names set explicitly in our L2s. I don't think it was adapted widely.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it was adapted widely.
Screen Shot 2020-08-03 at 8 02 06 AM

@mergify
Copy link
Contributor

mergify bot commented Aug 2, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 6253108
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Aug 2, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 8ab7b10 into aws:master Aug 2, 2020
@skinny85 skinny85 deleted the fix/dynamodb-physical-name-if-required-as-table-name branch August 3, 2020 14:55
curtiseppel pushed a commit to curtiseppel/aws-cdk that referenced this pull request Aug 11, 2020
@skinny85
fix(dynamodb): allow using PhysicalName.GENERATE_IF_NEEDED as the Tab…
eaf84a3 
…le name (aws#9377)

Fixes aws#9374

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NetaNir NetaNir NetaNir approved these changes

@RomainMuller RomainMuller Awaiting requested review from RomainMuller

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
3 participants
@skinny85 @aws-cdk-automation @NetaNir