Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloudfront): add support for Origin Groups #9360

Merged
merged 1 commit into from
Aug 3, 2020

Conversation

skinny85
Copy link
Contributor

Fixes #9109


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@skinny85 skinny85 requested a review from njlynch July 30, 2020 19:33
@skinny85 skinny85 self-assigned this Jul 30, 2020
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 30, 2020
@skinny85
Copy link
Contributor Author

Forgot to update the ReadMe... nice work automatic checker!

@skinny85 skinny85 force-pushed the feat/cloudfront-origin-groups branch from 3676e4a to e9babd7 Compare July 30, 2020 19:47
@skinny85
Copy link
Contributor Author

Forgot to update the ReadMe... nice work automatic checker!

Done!

Copy link
Contributor

@njlynch njlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! A couple of docs-related comments, but otherwise looks ok.

packages/@aws-cdk/aws-cloudfront-origins/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-cloudfront-origins/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-cloudfront/lib/distribution.ts Outdated Show resolved Hide resolved
@skinny85 skinny85 force-pushed the feat/cloudfront-origin-groups branch from e9babd7 to c1ae63f Compare July 31, 2020 23:20
@skinny85 skinny85 requested a review from njlynch July 31, 2020 23:20
@njlynch njlynch added the pr/do-not-merge This PR should not be merged at this time. label Aug 3, 2020
@skinny85 skinny85 force-pushed the feat/cloudfront-origin-groups branch from c1ae63f to ab0a43f Compare August 3, 2020 17:49
@skinny85 skinny85 removed the pr/do-not-merge This PR should not be merged at this time. label Aug 3, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: ab0a43f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Aug 3, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 11e146c into aws:master Aug 3, 2020
@skinny85 skinny85 deleted the feat/cloudfront-origin-groups branch August 3, 2020 18:15
eladb pushed a commit that referenced this pull request Aug 10, 2020
Fixes #9109

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
curtiseppel pushed a commit to curtiseppel/aws-cdk that referenced this pull request Aug 11, 2020
Fixes aws#9109

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CloudFront] Distribution - Origin Groups
3 participants